Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2738833002: MD Settings: minor string sweep. (Closed)

Created:
3 years, 9 months ago by scottchen
Modified:
3 years, 9 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: minor string sweep. BUG=699292 Review-Url: https://codereview.chromium.org/2738833002 Cr-Commit-Position: refs/heads/master@{#455335} Committed: https://chromium.googlesource.com/chromium/src/+/5bac656c5eca0d89ab234781dd5aa5f6c40c1a8d

Patch Set 1 #

Patch Set 2 : MD Settings: minor string sweep. #

Total comments: 2

Patch Set 3 : update string ID for consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/app/settings_google_chrome_strings.grdp View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/settings_strings.grdp View 1 2 8 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
scottchen
See https://docs.google.com/spreadsheets/d/17uvG_CTZ7N16B7hSdobwSc8VQO6xFPk2Q3Hz4dbKrx4/edit#gid=0
3 years, 9 months ago (2017-03-07 23:31:29 UTC) #2
dpapad
LGTM https://codereview.chromium.org/2738833002/diff/20001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2738833002/diff/20001/chrome/app/settings_strings.grdp#newcode444 chrome/app/settings_strings.grdp:444: <message name="IDS_SETTINGS_PASSWORD_VIEW_DETAILS" desc="Label for a context menu item ...
3 years, 9 months ago (2017-03-07 23:42:58 UTC) #3
scottchen
https://codereview.chromium.org/2738833002/diff/20001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2738833002/diff/20001/chrome/app/settings_strings.grdp#newcode444 chrome/app/settings_strings.grdp:444: <message name="IDS_SETTINGS_PASSWORD_VIEW_DETAILS" desc="Label for a context menu item that ...
3 years, 9 months ago (2017-03-08 00:47:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738833002/40001
3 years, 9 months ago (2017-03-08 00:48:25 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:52:14 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5bac656c5eca0d89ab234781dd5a...

Powered by Google App Engine
This is Rietveld 408576698