Chromium Code Reviews| Index: third_party/WebKit/Tools/Scripts/webkitpy/pylintrc |
| diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc b/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc |
| index 2465b0f85b78e06c85d8d7b477fdaee32cec6c5b..46dfda3458bcd69586e26c7e359863d5ab3434d3 100644 |
| --- a/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc |
| +++ b/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc |
| @@ -203,7 +203,13 @@ variable-rgx=[a-z_][a-z0-9_]{1,30}$ |
| inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ |
| # Good variable names which should always be accepted, separated by a comma. |
| -good-names=i,j,k,ex,Run,_,_log |
| +# These short names are acceptable in the following cases; |
|
qyearsley
2017/03/08 15:04:11
Nit: semicolon -> colon
mithro
2017/03/09 03:01:08
Done.
|
| +# _ - unused value |
| +# i/j/k/x - for XXX in range(): |
|
qyearsley
2017/03/08 15:04:11
Bikeshedding: I think in most cases where you'd wa
mithro
2017/03/09 03:01:09
Actually the case where x makes sense, y and z als
|
| +# e/ex/err - exception XXXError as e: |
|
qyearsley
2017/03/08 15:04:11
I'm not sure if ex and err need to be in the below
mithro
2017/03/09 03:01:09
I removed ex and exp but as the following is extre
|
| +# f/fd - with open('blah') as f: |
| +# _log/Run - webkitpy functions |
| +good-names=_,i,j,k,x,e,ex,err,f,fd,_log,Run |
| # Bad variable names which should always be refused, separated by a comma. |
| bad-names=foo,bar,baz,toto,tutu,tata |