Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/pylintrc

Issue 2738823003: webkitpy: Slightly adjusting pylintrc allow names. (Closed)
Patch Set: webkitpy: Slightly adjusting pylintrc allow names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 argument-rgx=[a-z_][a-z0-9_]{1,30}$ 196 argument-rgx=[a-z_][a-z0-9_]{1,30}$
197 197
198 # Regular expression which should only match correct variable names. 198 # Regular expression which should only match correct variable names.
199 variable-rgx=[a-z_][a-z0-9_]{1,30}$ 199 variable-rgx=[a-z_][a-z0-9_]{1,30}$
200 200
201 # Regular expression which should only match correct list comprehension or 201 # Regular expression which should only match correct list comprehension or
202 # generator expression variable names. 202 # generator expression variable names.
203 inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ 203 inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
204 204
205 # Good variable names which should always be accepted, separated by a comma. 205 # Good variable names which should always be accepted, separated by a comma.
206 good-names=i,j,k,ex,Run,_,_log 206 # These short names are acceptable in the following cases;
qyearsley 2017/03/08 15:04:11 Nit: semicolon -> colon
mithro 2017/03/09 03:01:08 Done.
207 # _ - unused value
208 # i/j/k/x - for XXX in range():
qyearsley 2017/03/08 15:04:11 Bikeshedding: I think in most cases where you'd wa
mithro 2017/03/09 03:01:09 Actually the case where x makes sense, y and z als
209 # e/ex/err - exception XXXError as e:
qyearsley 2017/03/08 15:04:11 I'm not sure if ex and err need to be in the below
mithro 2017/03/09 03:01:09 I removed ex and exp but as the following is extre
210 # f/fd - with open('blah') as f:
211 # _log/Run - webkitpy functions
212 good-names=_,i,j,k,x,e,ex,err,f,fd,_log,Run
207 213
208 # Bad variable names which should always be refused, separated by a comma. 214 # Bad variable names which should always be refused, separated by a comma.
209 bad-names=foo,bar,baz,toto,tutu,tata 215 bad-names=foo,bar,baz,toto,tutu,tata
210 216
211 # Regular expression which should only match functions or classes name which do 217 # Regular expression which should only match functions or classes name which do
212 # not require a docstring. 218 # not require a docstring.
213 no-docstring-rgx=__.*__ 219 no-docstring-rgx=__.*__
214 220
215 221
216 [DESIGN] 222 [DESIGN]
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 # Create a graph of internal dependencies in the given file (report RP0402 must 282 # Create a graph of internal dependencies in the given file (report RP0402 must
277 # not be disabled). 283 # not be disabled).
278 int-import-graph= 284 int-import-graph=
279 285
280 286
281 [EXCEPTIONS] 287 [EXCEPTIONS]
282 288
283 # Exceptions that will emit a warning when being caught. Defaults to 289 # Exceptions that will emit a warning when being caught. Defaults to
284 # "Exception". 290 # "Exception".
285 overgeneral-exceptions=Exception 291 overgeneral-exceptions=Exception
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698