Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2738813002: Remove unused PwCollection (Closed)

Created:
3 years, 9 months ago by cco3
Modified:
3 years, 9 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused PwCollection This class was created to help send results to UrlManager listeners, but the structure that is currently used lives in native. BUG=636490 Review-Url: https://codereview.chromium.org/2738813002 Cr-Commit-Position: refs/heads/master@{#456864} Committed: https://chromium.googlesource.com/chromium/src/+/d028bb17b6b7fd22c69e1a788a0e8c0dbc57ca30

Patch Set 1 #

Patch Set 2 : Update bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwCollection.java View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
cco3
3 years, 9 months ago (2017-03-07 20:42:55 UTC) #2
mattreynolds
lgtm
3 years, 9 months ago (2017-03-07 20:47:13 UTC) #3
cco3
Hi Tommy. This is another quick cleanup change.
3 years, 9 months ago (2017-03-07 20:47:51 UTC) #5
nyquist
lgtm. is there a bug that this cleanup should be attached to?
3 years, 9 months ago (2017-03-14 20:10:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738813002/20001
3 years, 9 months ago (2017-03-14 20:59:12 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 22:24:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d028bb17b6b7fd22c69e1a788a0e...

Powered by Google App Engine
This is Rietveld 408576698