Add a way to reconfigure cell from IndexPaths

Add a way to reconfigure cell from IndexPaths

Add a method to CollectionViewController to reconfigure cells based in their
index path instead.

BUG=none

Review-Url: https://codereview.chromium.org/2738743005
Cr-Commit-Position: refs/heads/master@{#455708}
Committed: https://chromium.googlesource.com/chromium/src/+/11b13107b7af731540d2042447b43e4d1b498c2a

[gambard, 2017-03-08 16:09:57]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org

[gambard, 2017-03-08 16:09:58]

PTAL.

[lpromero, 2017-03-08 17:30:19]

The test helpers feel a bit twisted in the second case. Maybe add comments to
separate more the arrange/act(/assert) parts.

https://codereview.chromium.org/2738743005/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/collection_view/collection_view_controller.mm
(right):

https://codereview.chromium.org/2738743005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/collection_view/collection_view_controller.mm:274: //
Reconfigure the cell at |indexPath| by calling |configureCell:| with |item|.
Reconfigures

https://codereview.chromium.org/2738743005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/collection_view/collection_view_controller.mm:275: -
(void)reconfigureCellsAtIndexPath:(NSIndexPath*)indexPath
cell

[lpromero, 2017-03-08 17:30:26]

And lgtm.

[gambard, 2017-03-09 09:02:04]

Thanks!
I agree that the second test is slightly twisted but I don't see how I can do it
differently. My assumption is that the "indexPathForItem:inSection:" is tested
elsewhere so it is ok to use it.

https://codereview.chromium.org/2738743005/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/collection_view/collection_view_controller.mm
(right):

https://codereview.chromium.org/2738743005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/collection_view/collection_view_controller.mm:274: //
Reconfigure the cell at |indexPath| by calling |configureCell:| with |item|.
On 2017/03/08 17:30:19, lpromero wrote:
> Reconfigures

Done.

https://codereview.chromium.org/2738743005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/collection_view/collection_view_controller.mm:275: -
(void)reconfigureCellsAtIndexPath:(NSIndexPath*)indexPath
On 2017/03/08 17:30:19, lpromero wrote:
> cell

Done.

[gambard, 2017-03-09 09:04:17]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-09 09:04:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2738743005/#ps60001
(title: "Add a comment")

[commit-bot: I haz the power, 2017-03-09 09:04:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 09:16:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489050257229290,
"parent_rev": "ac02a40177745391adfae78a83b05b177113b3c9", "commit_rev":
"11b13107b7af731540d2042447b43e4d1b498c2a"}

[commit-bot: I haz the power, 2017-03-09 09:17:47]

Description was changed from

==========
Add a way to reconfigure cell from IndexPaths

Add a method to CollectionViewController to reconfigure cells based in their
index path instead.

BUG=none
==========

to

==========
Add a way to reconfigure cell from IndexPaths

Add a method to CollectionViewController to reconfigure cells based in their
index path instead.

BUG=none

Review-Url: https://codereview.chromium.org/2738743005
Cr-Commit-Position: refs/heads/master@{#455708}
Committed:
https://chromium.googlesource.com/chromium/src/+/11b13107b7af731540d2042447b4...
==========

[commit-bot: I haz the power, 2017-03-09 09:17:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/11b13107b7af731540d2042447b4...