Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2738703006:
[WASM] Make F32x4 Tests pass on ARM hardware. (Closed)
|
Created:
3 years, 9 months ago by bbudge Modified:
3 years, 9 months ago Reviewers:
Mircea Trofin CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[WASM] Make F32x4 Tests pass on ARM hardware.
- Changes input filtering to test NaNs, but skip very large or very
small inputs, which may cause imprecision on some platforms.
- Changes expected result filtering to only skip NaNs.
LOG=N
BUG=6020
Review-Url: https://codereview.chromium.org/2738703006
Cr-Commit-Position: refs/heads/master@{#43681}
Committed: https://chromium.googlesource.com/v8/v8/+/cbfd9f5ede27717824727ae6f5bcc8c104b5f24a
Patch Set 1 #Patch Set 2 : Fix F32x4Splat test (skip NaN lane values.) #
Total comments: 1
Patch Set 3 : Fix Min, Max, which should return NaN if either operand is NaN. #Patch Set 4 : Fix comment. #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/18663) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bbudge@chromium.org changed reviewers: + mtrofin@chromium.org
I need to change this yet again to make the ARM bot green. PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)
lgtm https://codereview.chromium.org/2738703006/diff/20001/test/cctest/wasm/test-r... File test/cctest/wasm/test-run-wasm-simd.cc (right): https://codereview.chromium.org/2738703006/diff/20001/test/cctest/wasm/test-r... test/cctest/wasm/test-run-wasm-simd.cc:379: bool SkipFPTestInput(float x) { We should think about what our portability story is here. Offline, we talked about possibly having an interned API that tests the CPU capability. Then, the test can be evaluated at JIT time and elided, together with the path that won't be taken.
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/08 21:57:21, Mircea Trofin wrote: > lgtm > > https://codereview.chromium.org/2738703006/diff/20001/test/cctest/wasm/test-r... > File test/cctest/wasm/test-run-wasm-simd.cc (right): > > https://codereview.chromium.org/2738703006/diff/20001/test/cctest/wasm/test-r... > test/cctest/wasm/test-run-wasm-simd.cc:379: bool SkipFPTestInput(float x) { > We should think about what our portability story is here. Offline, we talked > about possibly having an interned API that tests the CPU capability. Then, the > test can be evaluated at JIT time and elided, together with the path that won't > be taken. I'm writing a doc on what's left for SIMD in WASM. I'll add a section on this for completeness.
The CQ bit was checked by bbudge@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org Link to the patchset: https://codereview.chromium.org/2738703006/#ps60001 (title: "Fix comment.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489016561767030,
"parent_rev": "c7ce19dcab241545645cea9b21c2aadf40e50a20", "commit_rev":
"cbfd9f5ede27717824727ae6f5bcc8c104b5f24a"}
Message was sent while issue was closed.
Description was changed from ========== [WASM] Make F32x4 Tests pass on ARM hardware. - Changes input filtering to test NaNs, but skip very large or very small inputs, which may cause imprecision on some platforms. - Changes expected result filtering to only skip NaNs. LOG=N BUG=6020 ========== to ========== [WASM] Make F32x4 Tests pass on ARM hardware. - Changes input filtering to test NaNs, but skip very large or very small inputs, which may cause imprecision on some platforms. - Changes expected result filtering to only skip NaNs. LOG=N BUG=6020 Review-Url: https://codereview.chromium.org/2738703006 Cr-Commit-Position: refs/heads/master@{#43681} Committed: https://chromium.googlesource.com/v8/v8/+/cbfd9f5ede27717824727ae6f5bcc8c104b... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/v8/v8/+/cbfd9f5ede27717824727ae6f5bcc8c104b... |
