Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2738653002: Fix memory management of VoiceSearchBarView. (Closed)

Created:
3 years, 9 months ago by kkhorimoto
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix memory management of VoiceSearchBarView. The VoiceSearchProvider is written in ARC, so the returned value is autoreleased despite the function having "Created" in the name. This CL correctly retains the returned value to prevent over-releasing the view. BUG=679719 Review-Url: https://codereview.chromium.org/2644703003 Cr-Commit-Position: refs/heads/master@{#445769} (cherry picked from commit d297fb597145bbfc86fb1c243091669f09dc6df5) Review-Url: https://codereview.chromium.org/2738653002 . Cr-Commit-Position: refs/branch-heads/2987@{#780} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/ebb52eebdb931dfab0012eb169a82f4b6064c072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/voice/voice_search_provider.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_provider.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kkhorimoto
3 years, 9 months ago (2017-03-07 05:33:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ebb52eebdb931dfab0012eb169a82f4b6064c072.

Powered by Google App Engine
This is Rietveld 408576698