Remove non-leaky LazyInstances in cc.

Remove non-leaky LazyInstances in cc.

We do this by removing the LazyInstances entirely.

EmptyContentLayerClient was part of production build targets (?) but
only used by tests. Switched to the equally capable
FakeContentLayerClient.

Changed the LazyInstances in FakeTileManager to be static pointers.

R=vmpstr@chromium.org
BUG=698982
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2738613006
Cr-Commit-Position: refs/heads/master@{#455852}
Committed: https://chromium.googlesource.com/chromium/src/+/298fdeb4da7e54f0c26e86e37a9460b401246c03

[danakj, 2017-03-08 18:52:53]

Description was changed from

==========
Remove non-leaky LazyInstances in cc.

We do this by removing the LazyInstances entirely.

EmptyContentLayerClient was part of production build targets (?) but
only used by tests. Switched to the equally capable
FakeContentLayerClient.

Changed the LazyInstances in FakeTileManager to be static pointers.

R=vmpstr@chromium.org
BUG=698982
==========

to

==========
Remove non-leaky LazyInstances in cc.

We do this by removing the LazyInstances entirely.

EmptyContentLayerClient was part of production build targets (?) but
only used by tests. Switched to the equally capable
FakeContentLayerClient.

Changed the LazyInstances in FakeTileManager to be static pointers.

R=vmpstr@chromium.org
BUG=698982
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-03-08 18:57:41]

Tests all pass if the FakeTileManager thingers are members - meaning not shared
between FakeTileManagers within a test.. which I don't know why would be
important, so I could do that if you want (that's patch set 1)

[danakj, 2017-03-08 18:57:47]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 18:58:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-03-08 19:04:42]

lgtm, I kind of weakly prefer PS1 since then you don't even have to address the
nits.

https://codereview.chromium.org/2738613006/diff/20001/cc/test/fake_tile_manag...
File cc/test/fake_tile_manager.cc (right):

https://codereview.chromium.org/2738613006/diff/20001/cc/test/fake_tile_manag...
cc/test/fake_tile_manager.cc:26: static SynchronousTaskGraphRunner* g = new
SynchronousTaskGraphRunner;
nit: g for global? How about graph_runner?

https://codereview.chromium.org/2738613006/diff/20001/cc/test/fake_tile_manag...
cc/test/fake_tile_manager.cc:31: static FakeRasterBufferProviderImpl* g = new
FakeRasterBufferProviderImpl;
nit: raster_buffer_provider?

[commit-bot: I haz the power, 2017-03-08 19:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 19:57:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2017-03-08 20:27:38]

Patchset #2 (id:20001) has been deleted

[danakj, 2017-03-08 20:27:41]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2017-03-08 20:27:57]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-03-08 20:28:01]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-03-08 20:28:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 22:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 22:05:45]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2017-03-09 17:02:52]

So, a lot of tests time out on Windows only with this..

[vmpstr, 2017-03-09 18:25:02]

On 2017/03/09 17:02:52, danakj wrote:
> So, a lot of tests time out on Windows only with this..

Hmm, some of those tests aren't even touched by this CL, but maybe they ran as a
group with the ones affected.

It might be something in the shutdown that blocks? Feel free to upload the patch
with the leaky statics instead

[danakj, 2017-03-09 19:31:57]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 19:33:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-03-09 20:06:54]

OK That seems to work. I renamed the vars as u nitted before.

[danakj, 2017-03-09 20:07:00]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-03-09 20:07:04]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-03-09 20:07:04]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2738613006/#ps40001
(title: "cc-remove-non-leaky-singletons: globals")

[commit-bot: I haz the power, 2017-03-09 20:07:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 20:26:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489090024594020,
"parent_rev": "11a12fd4575fef6f08ca5518ffc6714c7f41b615", "commit_rev":
"298fdeb4da7e54f0c26e86e37a9460b401246c03"}

[commit-bot: I haz the power, 2017-03-09 20:26:58]

Description was changed from

==========
Remove non-leaky LazyInstances in cc.

We do this by removing the LazyInstances entirely.

EmptyContentLayerClient was part of production build targets (?) but
only used by tests. Switched to the equally capable
FakeContentLayerClient.

Changed the LazyInstances in FakeTileManager to be static pointers.

R=vmpstr@chromium.org
BUG=698982
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove non-leaky LazyInstances in cc.

We do this by removing the LazyInstances entirely.

EmptyContentLayerClient was part of production build targets (?) but
only used by tests. Switched to the equally capable
FakeContentLayerClient.

Changed the LazyInstances in FakeTileManager to be static pointers.

R=vmpstr@chromium.org
BUG=698982
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2738613006
Cr-Commit-Position: refs/heads/master@{#455852}
Committed:
https://chromium.googlesource.com/chromium/src/+/298fdeb4da7e54f0c26e86e37a94...
==========

[commit-bot: I haz the power, 2017-03-09 20:26:59]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/298fdeb4da7e54f0c26e86e37a94...