[Chromecast] Fix ordering in PreMainMessageLoopRun

[Chromecast] Fix ordering in PreMainMessageLoopRun

UrlRequestContextFactory needs to be initialized before GetSystemGetter
is called.

Net log should be set before network activity starts.

BUG= internal b/35963633
TEST= Manual attempt to reproduce the crash

Review-Url: https://codereview.chromium.org/2738583003
Cr-Commit-Position: refs/heads/master@{#456113}
Committed: https://chromium.googlesource.com/chromium/src/+/2b274b77eb50f7decd55b62c0d3443e989e6f12b

[almasrymina, 2017-03-07 02:57:18]

Description was changed from

==========
[Chromecast] Fix ordering in PreMainMessageLoopRun

UrlRequestContextFactory needs to be initialized before GetSystemGetter
is called.

Net log should be set before network activity starts.

BUG= internal b/35963633
TEST= Manual attempt to reproduce the crash
==========

to

==========
[Chromecast] Fix ordering in PreMainMessageLoopRun

UrlRequestContextFactory needs to be initialized before GetSystemGetter
is called.

Net log should be set before network activity starts.

BUG= internal b/35963633
TEST= Manual attempt to reproduce the crash
==========

[almasrymina, 2017-03-07 02:57:18]

almasrymina@chromium.org changed reviewers:
+ halliwell@chromium.org, wzhong@chromium.org

[halliwell, 2017-03-07 19:23:29]

https://codereview.chromium.org/2738583003/diff/1/chromecast/browser/cast_bro...
File chromecast/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/2738583003/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:441:
url_request_context_factory_->InitializeOnUIThread(net_log_.get());
Is it worth a DCHECK in UrlRequestContextFactory that it's initialized before
calls to GetSystemGetter etc?

[almasrymina, 2017-03-09 19:19:21]

https://codereview.chromium.org/2738583003/diff/1/chromecast/browser/cast_bro...
File chromecast/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/2738583003/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:441:
url_request_context_factory_->InitializeOnUIThread(net_log_.get());
On 2017/03/07 19:23:29, halliwell wrote:
> Is it worth a DCHECK in UrlRequestContextFactory that it's initialized before
> calls to GetSystemGetter etc?

Done.

[almasrymina, 2017-03-09 19:19:29]

The CQ bit was checked by almasrymina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 19:20:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wzhong, 2017-03-09 19:25:03]

lgtm

[commit-bot: I haz the power, 2017-03-09 19:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 19:41:23]

Dry run: This issue passed the CQ dry run.

[halliwell, 2017-03-09 19:59:34]

On 2017/03/09 19:25:03, wzhong wrote:
> lgtm

lgtm

[almasrymina, 2017-03-10 18:21:16]

The CQ bit was checked by almasrymina@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:21:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 18:27:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489170076278310,
"parent_rev": "10983d0e7466db848a60f547db5124f13cdd8bde", "commit_rev":
"2b274b77eb50f7decd55b62c0d3443e989e6f12b"}

[commit-bot: I haz the power, 2017-03-10 18:28:36]

Description was changed from

==========
[Chromecast] Fix ordering in PreMainMessageLoopRun

UrlRequestContextFactory needs to be initialized before GetSystemGetter
is called.

Net log should be set before network activity starts.

BUG= internal b/35963633
TEST= Manual attempt to reproduce the crash
==========

to

==========
[Chromecast] Fix ordering in PreMainMessageLoopRun

UrlRequestContextFactory needs to be initialized before GetSystemGetter
is called.

Net log should be set before network activity starts.

BUG= internal b/35963633
TEST= Manual attempt to reproduce the crash

Review-Url: https://codereview.chromium.org/2738583003
Cr-Commit-Position: refs/heads/master@{#456113}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b274b77eb50f7decd55b62c0d34...
==========

[commit-bot: I haz the power, 2017-03-10 18:28:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b274b77eb50f7decd55b62c0d34...