Streamline the presentation of ImageBitmapRenderingContext

Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge class that provides a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readbacks when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2738573002
Cr-Commit-Position: refs/heads/master@{#462634}
Committed: https://chromium.googlesource.com/chromium/src/+/300bd53cd8a10fd63b4362b52bb6b6b92e345821

[Justin Novosad, 2017-03-06 22:23:33]

Description was changed from

==========
Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge clas that provide a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readback when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
==========

to

==========
Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge clas that provide a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readback when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Justin Novosad, 2017-03-06 22:23:33]

Description was changed from

==========
Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge clas that provide a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readback when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge clas that provide a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readback when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Justin Novosad, 2017-03-06 22:23:51]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 22:24:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2017-03-06 22:26:21]

junov@chromium.org changed reviewers:
+ dmazzoni@chromium.org, xlai@chromium.org, zmo@google.com

[Justin Novosad, 2017-03-06 22:26:22]

PTAL

@zmo: modules/webgl
@dmazzoni: modules/accessibility
@xlai: the rest.

[Justin Novosad, 2017-03-06 22:27:31]

Description was changed from

==========
Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge clas that provide a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readback when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge class that provides a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readbacks when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2017-03-06 22:44:38]

On 2017/03/06 22:26:22, Justin Novosad wrote:
> PTAL
> 
> @zmo: modules/webgl
> @dmazzoni: modules/accessibility
> @xlai: the rest.

modules/webgl lgtm

[commit-bot: I haz the power, 2017-03-06 22:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 22:59:26]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2017-03-08 23:50:30]

lgtm for modules/accessibility

[xlai (Olivia), 2017-03-09 21:57:27]

Please fix the failed bots as well.

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:176:
return isAccelerated();
Your CL is about decoupling canvas being composited and being accelerated. Why
are they equivalent in here then?

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp
(left):

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp:47:
// TODO(ccameron): Determine the correct color behavior here.
I think you accidentally took away this TODO comment when you transfer part of
the code to the new imagelayerbridge.

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/ImageBitmapLayerBridge.cpp
(right):

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/ImageBitmapLayerBridge.cpp:5:
class PLATFORM_EXPORT ImageBitmapLayerBridge
What is this class doing here?

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp
(right):

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp:35:
m_layer->setBlendBackgroundColor(false);
Do you need to consider the "premultiplied alpha" attribute of the layer?

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp:102: for
(int row = 0; row < m_image->height(); row++) {
Why do you do this loop? The source (x, y) seems to be fixed, is that what you
intent to do? Do you have an existing test that covers this?

[Justin Novosad, 2017-03-10 21:07:33]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 21:07:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2017-03-10 21:09:59]

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:176:
return isAccelerated();
On 2017/03/09 21:57:27, xlai (Olivia) wrote:
> Your CL is about decoupling canvas being composited and being accelerated. Why
> are they equivalent in here then?

For 2D canvas and WebGL, they are equivalent, but at the higher abstraction
level (CanvasRenderingContext), they are not.  The is because of the change to
ImageBitmapRenderingContext.

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp
(left):

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp:47:
// TODO(ccameron): Determine the correct color behavior here.
On 2017/03/09 21:57:27, xlai (Olivia) wrote:
> I think you accidentally took away this TODO comment when you transfer part of
> the code to the new imagelayerbridge.

Don't worry, ccameron removed this concurently in another CL that just landed.

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/ImageBitmapLayerBridge.cpp
(right):

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/ImageBitmapLayerBridge.cpp:5:
class PLATFORM_EXPORT ImageBitmapLayerBridge
On 2017/03/09 21:57:27, xlai (Olivia) wrote:
> What is this class doing here?

Whoops. I made a mistake when I renamed this file. File removed.

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp
(right):

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp:35:
m_layer->setBlendBackgroundColor(false);
On 2017/03/09 21:57:27, xlai (Olivia) wrote:
> Do you need to consider the "premultiplied alpha" attribute of the layer?

Turns out I don't. Premul is assumed here.  FWIW, we already have layout tests
with semi-transparent ImageBitmapRenderingContexts and they still pass with this
change.

https://codereview.chromium.org/2738573002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp:102: for
(int row = 0; row < m_image->height(); row++) {
On 2017/03/09 21:57:27, xlai (Olivia) wrote:
> Why do you do this loop? The source (x, y) seems to be fixed, is that what you
> intent to do? Do you have an existing test that covers this?

This is to do a y-flip on the image data.  For some reason Skia and SharedBitmpa
don't use the same orientation.  And skia has no option for flipping vertically
with readPixels.

[commit-bot: I haz the power, 2017-03-10 21:11:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:11:51]

Dry run: Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Justin Novosad, 2017-03-13 18:46:46]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 18:47:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 19:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 19:14:22]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Justin Novosad, 2017-03-23 16:05:59]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[Justin Novosad, 2017-03-23 16:06:25]

New patch

[commit-bot: I haz the power, 2017-03-23 16:06:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2017-03-23 16:06:53]

On 2017/03/23 16:06:25, Justin Novosad wrote:
> New patch

@xlai PTAL

[commit-bot: I haz the power, 2017-03-23 16:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:20:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Justin Novosad, 2017-03-24 17:31:02]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 17:31:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:13:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 18:13:42]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[xlai (Olivia), 2017-03-24 19:12:42]

lgtm with nits

https://codereview.chromium.org/2738573002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h
(right):

https://codereview.chromium.org/2738573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h:58:
bool isAccelerated() final { return true; }
You don't need to add this function. isTextureBacked() is doing the same thing.

[Justin Novosad, 2017-03-24 20:18:05]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2017-03-24 20:18:06]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
dmazzoni@chromium.org, xlai@chromium.org
Link to the patchset: https://codereview.chromium.org/2738573002/#ps60001
(title: "tweaks")

[commit-bot: I haz the power, 2017-03-24 20:19:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:22:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 21:22:54]

Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[Justin Novosad, 2017-04-06 15:25:11]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 15:25:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2017-04-06 16:24:35]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2017-04-06 16:24:35]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
xlai@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2738573002/#ps100001
(title: "spv2 suppressions and pixel test rebaselines")

[commit-bot: I haz the power, 2017-04-06 16:33:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:10:11]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Justin Novosad, 2017-04-06 19:06:57]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2017-04-06 19:06:58]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
xlai@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2738573002/#ps120001
(title: "pixel test expectations")

[commit-bot: I haz the power, 2017-04-06 19:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2017-04-06 19:26:06]

The CQ bit was unchecked by junov@chromium.org

[Justin Novosad, 2017-04-06 19:39:58]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2017-04-06 19:39:59]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
xlai@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2738573002/#ps140001
(title: "Fixed expectations")

[commit-bot: I haz the power, 2017-04-06 19:40:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:49:16]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1491507598569920,
"parent_rev": "3cf0cf68b3930de4aaac19a00ed8b8f0fd0e6ee3", "commit_rev":
"300bd53cd8a10fd63b4362b52bb6b6b92e345821"}

[commit-bot: I haz the power, 2017-04-06 21:50:08]

Description was changed from

==========
Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge class that provides a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readbacks when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Streamline the presentation of ImageBitmapRenderingContext

This change adds an ImageLayerBridge class that provides a direct
compositing path for displaying ImageBitmap objects, without
going through a blink paint pass.  As a consequence, there are
no more GPU readbacks when the source of the image is
GPU-accelerated.

In canvas rendering context classes, the notion of being
accelerated had to be decoupled from the notion of being
composited.  This is because non-accelerated canvases are
are directly composited with ImageBitmapRenderingContext.

BUG=696224, 585607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2738573002
Cr-Commit-Position: refs/heads/master@{#462634}
Committed:
https://chromium.googlesource.com/chromium/src/+/300bd53cd8a10fd63b4362b52bb6...
==========

[commit-bot: I haz the power, 2017-04-06 21:50:10]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/300bd53cd8a10fd63b4362b52bb6...