chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 2738553002: [Extensions] Log instances of invalid extensions being added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 2738553002: [Extensions] Log instances of invalid extensions being added (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_application_list_model_unittest.cc ('k') | chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index e8798fd378a5511ea6bc679cf870818f14a37404..1d609a48005e0dd0a9c982ba948c8f0ea20c3544 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -342,13 +342,9 @@ TEST_F(RulesRegistryWithCacheTest, RulesPreservedAcrossRestart) {

// 1. Add an extension, before rules registry gets created.

std::string error;

- scoped_refptr<Extension> extension(

- LoadManifestUnchecked("permissions",

- "web_request_all_host_permissions.json",

- Manifest::INVALID_LOCATION,

- Extension::NO_FLAGS,

- extension1_->id(),

- &error));

+ scoped_refptr<Extension> extension(LoadManifestUnchecked(

+ "permissions", "web_request_all_host_permissions.json",

+ Manifest::UNPACKED, Extension::NO_FLAGS, extension1_->id(), &error));

ASSERT_TRUE(error.empty());

extension_service->AddExtension(extension.get());

EXPECT_TRUE(extensions::ExtensionRegistry::Get(env_.profile())