chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc - Issue 2738553002: [Extensions] Log instances of invalid extensions being added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

Issue 2738553002: [Extensions] Log instances of invalid extensions being added (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc ('k') | chrome/browser/extensions/extension_action_icon_factory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

index 30d379c870879ed53dc922e42915a3b6614f97cf..d1d54f7dad3f035f37b7aff8cbb445078f3d8915 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

@@ -172,7 +172,7 @@ class ExtensionInfoGeneratorUnitTest : public ExtensionServiceTestBase {

// Produce test output.

std::unique_ptr<developer::ExtensionInfo> info =

- CreateExtensionInfoFromPath(extension_path, Manifest::INVALID_LOCATION);

+ CreateExtensionInfoFromPath(extension_path, Manifest::UNPACKED);

info->views = std::move(views);

std::unique_ptr<base::DictionaryValue> actual_output_data = info->ToValue();

ASSERT_TRUE(actual_output_data);