Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 2738523002: Add importorder to Java styleguide. (Closed)

Created:
3 years, 9 months ago by nyquist
Modified:
3 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add importorder to Java styleguide. The styleguide refers to the Android Style Guide unless exceptions are listed. However, the package import order is not listed as an exception, even though it does not match the Android Style Guide. This CL adds a section about the requirements for the Java import order. It does not refer to how to set this up in Eclipse and Android Studio, since that is already listed under the tools-section. BUG=None Review-Url: https://codereview.chromium.org/2738523002 Cr-Commit-Position: refs/heads/master@{#454965} Committed: https://chromium.googlesource.com/chromium/src/+/2d192c4cd3bfde6c10711cb061a592e65e57bdf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M styleguide/java/java.md View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nyquist
tedchoc: PTAL This is how patch set 1 looks like: https://chromium.googlesource.com/chromium/src/+/48fdf4d3ab9aab247b785787a6833d2e431cead2/styleguide/java/java.md#Import-Order
3 years, 9 months ago (2017-03-06 20:02:28 UTC) #2
Ted C
lgtm
3 years, 9 months ago (2017-03-06 21:00:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738523002/1
3 years, 9 months ago (2017-03-06 21:23:08 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 21:37:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d192c4cd3bfde6c10711cb061a5...

Powered by Google App Engine
This is Rietveld 408576698