Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2738513006: Add error initialization for network request class (Closed)

Created:
3 years, 9 months ago by apisarev
Modified:
3 years, 9 months ago
Reviewers:
asanka
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add error initialization for network request class Currently error member of RequestCore class not initialized. This cause MSan error in net_unittests. To fix it was initialized by OK value. BUG=None R=asanka@chromium.org Review-Url: https://codereview.chromium.org/2738513006 Cr-Commit-Position: refs/heads/master@{#455718} Committed: https://chromium.googlesource.com/chromium/src/+/b348620b14101e7861728a3876f66ef8d964a846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cert_net/cert_net_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
apisarev
3 years, 9 months ago (2017-03-07 09:17:54 UTC) #1
asanka
lgtm
3 years, 9 months ago (2017-03-07 19:02:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738513006/1
3 years, 9 months ago (2017-03-09 10:11:30 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 11:26:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b348620b14101e7861728a3876f6...

Powered by Google App Engine
This is Rietveld 408576698