Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Issue 2738513004: TestInterfaces: support delegate clearing. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TestInterfaces: support delegate clearing. Following r454834, the implementation of SetDelegate() also needs to handle resetting of the test delegate. R= BUG=698713 Review-Url: https://codereview.chromium.org/2738513004 Cr-Commit-Position: refs/heads/master@{#455030} Committed: https://chromium.googlesource.com/chromium/src/+/a9c462ea8bf9588c2a6859e7fe9fde1e4c7f7353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/shell/test_runner/test_interfaces.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
sof
please take a look.
3 years, 9 months ago (2017-03-06 22:17:56 UTC) #3
tkent
lgtm
3 years, 9 months ago (2017-03-06 22:50:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738513004/1
3 years, 9 months ago (2017-03-07 03:33:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a9c462ea8bf9588c2a6859e7fe9fde1e4c7f7353
3 years, 9 months ago (2017-03-07 03:41:20 UTC) #12
sof
3 years, 9 months ago (2017-03-07 06:41:20 UTC) #13
Message was sent while issue was closed.
thanks, and for sending it along sooner.

Powered by Google App Engine
This is Rietveld 408576698