Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2738483002: [turbofan] Introduce TruncateTaggedPointerToBit operator. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce TruncateTaggedPointerToBit operator. Oftentimes we can avoid the Smi check for ToBoolean truncations, since we already know that the input is always going to be a HeapObject. So introduce a dedicated TruncateTaggedPointerToBit operator, which uses the fact that the input is known to be a HeapObject. BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2738483002 Cr-Commit-Position: refs/heads/master@{#43629} Committed: https://chromium.googlesource.com/v8/v8/+/95d808670e37d660f9eb8d76546587c8fe52167d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +50 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-06 19:23:15 UTC) #1
Jarin
lgtm, even though I am getting worried about this piling up of code here without ...
3 years, 9 months ago (2017-03-07 10:08:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738483002/1
3 years, 9 months ago (2017-03-07 10:09:37 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 10:11:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/95d808670e37d660f9eb8d76546587c8fe5...

Powered by Google App Engine
This is Rietveld 408576698