Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2738463003: <input type=number>: accept localized digits without showing them. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<input type=number>: accept localized digits without showing them. Locale::stripInvalidNumberCharacters() missed to call initializeLocaleData(). BUG=694391 Review-Url: https://codereview.chromium.org/2738463003 Cr-Commit-Position: refs/heads/master@{#455286} Committed: https://chromium.googlesource.com/chromium/src/+/627d462e4a1fb99efa5d66caf6648a5cb246ffa6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/PlatformLocale.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/PlatformLocale.cpp View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/platform/text/PlatformLocaleTest.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
tkent
keishi@, would you review this please?
3 years, 9 months ago (2017-03-07 06:16:01 UTC) #4
keishi
LGTM
3 years, 9 months ago (2017-03-07 06:25:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738463003/1
3 years, 9 months ago (2017-03-07 09:24:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/379457)
3 years, 9 months ago (2017-03-07 11:36:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738463003/1
3 years, 9 months ago (2017-03-07 20:53:46 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:29:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/627d462e4a1fb99efa5d66caf664...

Powered by Google App Engine
This is Rietveld 408576698