Pref service: integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

Pref service: integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

This adds:
- PrefServiceControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- CreatePersistentPrefStore: A factory function that builds a
  PersistentPrefStoreImpl instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the
PrefServiceControl interface and provide access to the
PersistentPrefStore interface.

BUG=654988
Review-Url: https://codereview.chromium.org/2738353002
Cr-Commit-Position: refs/heads/master@{#456307}
Committed: https://chromium.googlesource.com/chromium/src/+/4c08113e52ecd6222a4ae0c3e4ee3676a04a94d5

[Sam McNally, 2017-03-10 02:41:33]

Description was changed from

==========
Pref service: Integrate user prefs with PrefStoreManagerImpl.

This adds:
- PrefStoreControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- user_prefs_factory: A factory function that builds a UserPrefs
  instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the PrefStoreControl
interface and provide access to the PersistentPrefStore interface.

BUG=654988
==========

to

==========
Pref service: Integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

This adds:
- PrefServiceControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- user_prefs_factory: A factory function that builds a
  PersistentPrefStoreImpl instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the
PrefServiceControl interface and provide access to the
PersistentPrefStore interface.

BUG=654988
==========

[Sam McNally, 2017-03-10 02:44:21]

Description was changed from

==========
Pref service: Integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

This adds:
- PrefServiceControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- user_prefs_factory: A factory function that builds a
  PersistentPrefStoreImpl instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the
PrefServiceControl interface and provide access to the
PersistentPrefStore interface.

BUG=654988
==========

to

==========
Pref service: Integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

This adds:
- PrefServiceControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- CreatePersistentPrefStore: A factory function that builds a
  PersistentPrefStoreImpl instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the
PrefServiceControl interface and provide access to the
PersistentPrefStore interface.

BUG=654988
==========

[Sam McNally, 2017-03-10 02:44:31]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 02:45:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-03-10 02:45:48]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2017-03-10 02:57:30]

Description was changed from

==========
Pref service: Integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

This adds:
- PrefServiceControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- CreatePersistentPrefStore: A factory function that builds a
  PersistentPrefStoreImpl instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the
PrefServiceControl interface and provide access to the
PersistentPrefStore interface.

BUG=654988
==========

to

==========
Pref service: integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

This adds:
- PrefServiceControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- CreatePersistentPrefStore: A factory function that builds a
  PersistentPrefStoreImpl instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the
PrefServiceControl interface and provide access to the
PersistentPrefStore interface.

BUG=654988
==========

[Sam McNally, 2017-03-10 02:57:39]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 02:57:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 03:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 03:00:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Sam McNally, 2017-03-10 03:31:33]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2017-03-10 03:32:12]

Patchset #2 (id:40001) has been deleted

[Sam McNally, 2017-03-10 03:32:14]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-03-10 03:32:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-03-10 03:33:47]

sammc@chromium.org changed reviewers:
+ tibell@chromium.org

[tibell, 2017-03-10 04:20:24]

lgtm

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
File services/preferences/public/cpp/pref_store_manager_impl.cc (right):

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
services/preferences/public/cpp/pref_store_manager_impl.cc:149: return;
Is this an error condition we want to warn about?

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
File services/preferences/public/cpp/pref_store_manager_impl.h (right):

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
services/preferences/public/cpp/pref_store_manager_impl.h:106:
std::vector<mojom::PersistentPrefStoreConnectorRequest>
Add:

// Requests made to connect to the service before it has been initialized. We
will complete those when initialization completes.

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
File services/preferences/public/interfaces/preferences.mojom (right):

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
services/preferences/public/interfaces/preferences.mojom:138:
Init(PersistentPrefStoreConfiguration configuration);
Add a comment saying this must be called before the service can be used.

[Sam McNally, 2017-03-10 04:29:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 04:30:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-03-10 05:06:55]

sammc@chromium.org changed reviewers:
+ mbarbella@chromium.org, mlerman@chromium.org

[Sam McNally, 2017-03-10 05:06:56]

+mbarbella for the mojom

+mlerman for //chrome/browser/profiles

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
File services/preferences/public/cpp/pref_store_manager_impl.cc (right):

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
services/preferences/public/cpp/pref_store_manager_impl.cc:149: return;
On 2017/03/10 04:20:24, tibell wrote:
> Is this an error condition we want to warn about?

Done.

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
File services/preferences/public/cpp/pref_store_manager_impl.h (right):

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
services/preferences/public/cpp/pref_store_manager_impl.h:106:
std::vector<mojom::PersistentPrefStoreConnectorRequest>
On 2017/03/10 04:20:24, tibell wrote:
> Add:
> 
> // Requests made to connect to the service before it has been initialized. We
> will complete those when initialization completes.

Done.

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
File services/preferences/public/interfaces/preferences.mojom (right):

https://codereview.chromium.org/2738353002/diff/60001/services/preferences/pu...
services/preferences/public/interfaces/preferences.mojom:138:
Init(PersistentPrefStoreConfiguration configuration);
On 2017/03/10 04:20:24, tibell wrote:
> Add a comment saying this must be called before the service can be used.

Done.

[commit-bot: I haz the power, 2017-03-10 05:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 05:28:36]

Dry run: This issue passed the CQ dry run.

[Mike Lerman, 2017-03-10 14:11:44]

profiles LGTM

[Martin Barbella, 2017-03-10 21:05:06]

mojom lgtm

[Sam McNally, 2017-03-12 22:07:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 22:07:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 23:18:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-12 23:18:07]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2017-03-12 23:31:46]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-03-12 23:31:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tibell@chromium.org
Link to the patchset: https://codereview.chromium.org/2738353002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2017-03-12 23:32:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 23:35:37]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489361506975410,
"parent_rev": "564fe924388fd462939f76cb1894dbface5eef71", "commit_rev":
"4c08113e52ecd6222a4ae0c3e4ee3676a04a94d5"}

[commit-bot: I haz the power, 2017-03-12 23:36:22]

Description was changed from

==========
Pref service: integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

This adds:
- PrefServiceControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- CreatePersistentPrefStore: A factory function that builds a
  PersistentPrefStoreImpl instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the
PrefServiceControl interface and provide access to the
PersistentPrefStore interface.

BUG=654988
==========

to

==========
Pref service: integrate PersistentPrefStoreImpl with PrefStoreManagerImpl.

This adds:
- PrefServiceControl: a mojo configuration interface that can be used
  to control where the pref service persists its user prefs.

- CreatePersistentPrefStore: A factory function that builds a
  PersistentPrefStoreImpl instance based on a configuration struct.

This also changes PrefStoreManagerImpl to implement the
PrefServiceControl interface and provide access to the
PersistentPrefStore interface.

BUG=654988

Review-Url: https://codereview.chromium.org/2738353002
Cr-Commit-Position: refs/heads/master@{#456307}
Committed:
https://chromium.googlesource.com/chromium/src/+/4c08113e52ecd6222a4ae0c3e4ee...
==========

[commit-bot: I haz the power, 2017-03-12 23:36:23]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4c08113e52ecd6222a4ae0c3e4ee...