Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart

Issue 2738313002: rename fasta.Token.value --> lexeme (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart
diff --git a/pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart b/pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart
index 1cb904fbec2e1fdadc3bf6d60d6bc1de7f5c2f1d..6008410f1a2f223e8cf4129e98cb5e058181b2dd 100644
--- a/pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart
+++ b/pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart
@@ -125,7 +125,7 @@ abstract class ArrayBasedScanner extends AbstractScanner {
}
/**
- * Appends a token that begins a new group, represented by [value].
+ * Appends a token that begins a new group, represented by [lexeme].
ahe 2017/03/10 07:26:11 I think this should be [info] instead.
danrubel 2017/03/11 22:10:38 Good point. Fixed.
* Group begin tokens are '{', '(', '[' and '${'.
*/
void appendBeginGroup(PrecedenceInfo info) {
@@ -138,7 +138,7 @@ abstract class ArrayBasedScanner extends AbstractScanner {
}
/**
- * Appends a token that begins an end group, represented by [value].
+ * Appends a token that begins an end group, represented by [lexeme].
ahe 2017/03/10 07:26:11 Ditto.
danrubel 2017/03/11 22:10:38 Done.
* It handles the group end tokens '}', ')' and ']'. The tokens '>' and
* '>>' are handled separately bo [appendGt] and [appendGtGt].
*/

Powered by Google App Engine
This is Rietveld 408576698