rename fasta.Token.value --> lexeme

pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.scanner.array_based_scanner;
 
 import 'error_token.dart' show ErrorToken;
 
 import 'keyword.dart' show Keyword;
 
@@ skipping 107 matching lines @@
    * Notifies on [$LF] characters in multi-line comments or strings.
    *
    * This method is used by the scanners to track line breaks and create the
    * [lineStarts] map.
    */
   void lineFeedInMultiline() {
     lineStarts.add(stringOffset + 1);
   }
 
   /**
-   * Appends a token that begins a new group, represented by [value].
+   * Appends a token that begins a new group, represented by [lexeme].

[ahe, 2017/03/10 07:26:11]

I think this should be [info] instead.

[danrubel, 2017/03/11 22:10:38]

Good point. Fixed.

    * Group begin tokens are '{', '(', '[' and '${'.
    */
   void appendBeginGroup(PrecedenceInfo info) {
     Token token = new BeginGroupToken(info, tokenStart);
     appendToken(token);
 
     // { (  [ ${ cannot appear inside a type parameters / arguments.
     if (!identical(info.kind, LT_TOKEN)) discardOpenLt();
     groupingStack = groupingStack.prepend(token);
   }
 
   /**
-   * Appends a token that begins an end group, represented by [value].
+   * Appends a token that begins an end group, represented by [lexeme].

[ahe, 2017/03/10 07:26:11]

Ditto.

[danrubel, 2017/03/11 22:10:38]

Done.

    * It handles the group end tokens '}', ')' and ']'. The tokens '>' and
    * '>>' are handled separately bo [appendGt] and [appendGtGt].
    */
   int appendEndGroup(PrecedenceInfo info, int openKind) {
     assert(!identical(openKind, LT_TOKEN)); // openKind is < for > and >>
     discardBeginGroupUntil(openKind);
     appendPrecedenceToken(info);
     Token close = tail;
     if (groupingStack.isEmpty) {
       return advance();
@@ skipping 113 matching lines @@
    * something which cannot possibly be part of a type parameter/argument
    * list, like the '=' in the above example.
    */
   void discardOpenLt() {
     while (!groupingStack.isEmpty &&
         identical(groupingStack.head.kind, LT_TOKEN)) {
       groupingStack = groupingStack.tail;
     }
   }
 }