rename fasta.Token.value --> lexeme

rename fasta.Token.value --> lexeme

This renames the fasta.Token.value field to .lexeme so that
it will not collide with an already existing analyzer.Token accessor.

R=ahe@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/42f6586f36d2d58a70f5896314fd2a94871256ca

[danrubel, 2017-03-09 21:38:18]

danrubel@google.com changed reviewers:
+ ahe@google.com, paulberry@google.com

[Paul Berry, 2017-03-09 22:43:14]

lgtm

[ahe, 2017-03-10 07:26:11]

Thank you, Dan!

I think you may have cast a too wide net, but assuming you undo the unrelated
changes: LGTM

Although I for some reason dislike the word lexeme (how irrational of me), this
change is super nice now that you clarified the exact meaning of lexeme to me. I
noticed other places where "lexeme" would be the right word to use, but that's
mostly in code that will hopefully soon be retired.

https://codereview.chromium.org/2738313002/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/codegen_dart_protocol.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/codegen_dart_protocol.dart:1230: * of the [lexeme]
variable is known.
Are you sure about the changes to this file?

https://codereview.chromium.org/2738313002/diff/1/pkg/analyzer/lib/src/dart/c...
File pkg/analyzer/lib/src/dart/constant/value.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/analyzer/lib/src/dart/c...
pkg/analyzer/lib/src/dart/constant/value.dart:2770: * Initialize a newly created
state to represent the given [lexeme].
And this file?

https://codereview.chromium.org/2738313002/diff/1/pkg/analyzer/lib/task/model...
File pkg/analyzer/lib/task/model.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/analyzer/lib/task/model...
pkg/analyzer/lib/task/model.dart:657: * Return the [lexeme] that was computed by
this builder.
And this?

https://codereview.chromium.org/2738313002/diff/1/pkg/compiler/lib/src/js/rew...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/compiler/lib/src/js/rew...
pkg/compiler/lib/src/js/rewrite_async.dart:1831: /// `yield*` wraps [lexeme] in
a [yieldStarExpression] and returns it.
I think this isn't related. But there's an opportunity to be a good citizen
here: I think they meant [expression] in both cases.

https://codereview.chromium.org/2738313002/diff/1/pkg/compiler/lib/src/patch_...
File pkg/compiler/lib/src/patch_parser.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/compiler/lib/src/patch_...
pkg/compiler/lib/src/patch_parser.dart:437: annotation.beginToken != null &&
annotation.beginToken.next.lexeme == 'JS';
Long line.

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:128:
toAnalyzerToken(first), unescapeFirstStringPart(first.lexeme, quote)));
Long line.

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart:128: * Appends a
token that begins a new group, represented by [lexeme].
I think this should be [info] instead.

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart:141: * Appends a
token that begins an end group, represented by [lexeme].
Ditto.

[danrubel, 2017-03-11 22:10:29]

On 2017/03/10 07:26:11, ahe wrote:
> Thank you, Dan!
> 
> I think you may have cast a too wide net, but assuming you undo the unrelated
> changes: LGTM

Thanks for looking this over.
I put too much reliance in the accuracy of automated refactoring and did not
check it closely enough.

[danrubel, 2017-03-11 22:10:38]

https://codereview.chromium.org/2738313002/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/codegen_dart_protocol.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/codegen_dart_protocol.dart:1230: * of the [lexeme]
variable is known.
On 2017/03/10 07:26:10, ahe wrote:
> Are you sure about the changes to this file?

Good catch. This file should not be changed. Fixed.

https://codereview.chromium.org/2738313002/diff/1/pkg/analyzer/lib/src/dart/c...
File pkg/analyzer/lib/src/dart/constant/value.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/analyzer/lib/src/dart/c...
pkg/analyzer/lib/src/dart/constant/value.dart:2770: * Initialize a newly created
state to represent the given [lexeme].
On 2017/03/10 07:26:10, ahe wrote:
> And this file?

Reverted.

https://codereview.chromium.org/2738313002/diff/1/pkg/analyzer/lib/task/model...
File pkg/analyzer/lib/task/model.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/analyzer/lib/task/model...
pkg/analyzer/lib/task/model.dart:657: * Return the [lexeme] that was computed by
this builder.
On 2017/03/10 07:26:11, ahe wrote:
> And this?

Reverted.

https://codereview.chromium.org/2738313002/diff/1/pkg/compiler/lib/src/js/rew...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/compiler/lib/src/js/rew...
pkg/compiler/lib/src/js/rewrite_async.dart:1831: /// `yield*` wraps [lexeme] in
a [yieldStarExpression] and returns it.
On 2017/03/10 07:26:11, ahe wrote:
> I think this isn't related. But there's an opportunity to be a good citizen
> here: I think they meant [expression] in both cases.

Reverted.

https://codereview.chromium.org/2738313002/diff/1/pkg/compiler/lib/src/patch_...
File pkg/compiler/lib/src/patch_parser.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/compiler/lib/src/patch_...
pkg/compiler/lib/src/patch_parser.dart:437: annotation.beginToken != null &&
annotation.beginToken.next.lexeme == 'JS';
On 2017/03/10 07:26:11, ahe wrote:
> Long line.

Reformatted.

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:128:
toAnalyzerToken(first), unescapeFirstStringPart(first.lexeme, quote)));
On 2017/03/10 07:26:11, ahe wrote:
> Long line.

Reformatted.

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart (right):

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart:128: * Appends a
token that begins a new group, represented by [lexeme].
On 2017/03/10 07:26:11, ahe wrote:
> I think this should be [info] instead.

Good point. Fixed.

https://codereview.chromium.org/2738313002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart:141: * Appends a
token that begins an end group, represented by [lexeme].
On 2017/03/10 07:26:11, ahe wrote:
> Ditto.

Done.

[danrubel, 2017-03-12 17:16:20]

Description was changed from

==========
rename fasta.Token.value --> lexeme

This renames the fasta.Token.value field to .lexeme so that
it will not collide with an already existing analyzer.Token accessor.
==========

to

==========
rename fasta.Token.value --> lexeme

This renames the fasta.Token.value field to .lexeme so that
it will not collide with an already existing analyzer.Token accessor.

R=ahe@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/42f6586f36d2d58a70f5896314fd2a94871256ca
==========

[danrubel, 2017-03-12 17:16:22]

Committed patchset #5 (id:80001) manually as
42f6586f36d2d58a70f5896314fd2a94871256ca (presubmit successful).