Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2738233002: Fold SVGDocumentExtensions::reportError into only user (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fold SVGDocumentExtensions::reportError into only user This method only had a single user, and it seems like it could just call Document::addConsoleMessage directly. Also remove a stray 'public' access specifier by moving the single method in it up a bit in the file. Review-Url: https://codereview.chromium.org/2738233002 Cr-Commit-Position: refs/heads/master@{#455802} Committed: https://chromium.googlesource.com/chromium/src/+/f8e4017f550a8553187afb08de1835efe5114445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 9 months ago (2017-03-09 17:23:31 UTC) #4
pdr.
On 2017/03/09 at 17:23:31, fs wrote: > LGTM
3 years, 9 months ago (2017-03-09 17:43:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738233002/1
3 years, 9 months ago (2017-03-09 18:30:11 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:35:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8e4017f550a8553187afb08de18...

Powered by Google App Engine
This is Rietveld 408576698