Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2738213004: Range: surroundContents() should postpone DOM mutation events. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Range: surroundContents() should postpone DOM mutation events. We should do so in order to avoid code/test complexity by DOM mutation events. BUG=539758 Review-Url: https://codereview.chromium.org/2738213004 Cr-Commit-Position: refs/heads/master@{#455979} Committed: https://chromium.googlesource.com/chromium/src/+/fd6d973ee6a4c853542cf4ec2a78dfd294322402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -30 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Range/surroundContents-crash.html View 2 chunks +9 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Range/surroundContents-crash-expected.txt View 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
yosin@, would you review this please?
3 years, 9 months ago (2017-03-10 02:13:31 UTC) #4
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-10 03:41:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738213004/1
3 years, 9 months ago (2017-03-10 03:41:51 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 03:51:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd6d973ee6a4c853542cf4ec2a78...

Powered by Google App Engine
This is Rietveld 408576698