Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2738213003: Revert of cmaa, gpu: use R8 image texture when GL_NV_image_formats is available. (Closed)

Created:
3 years, 9 months ago by Zhenyao Mo
Modified:
3 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Henrik Grunell, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cmaa, gpu: use R8 image texture when GL_NV_image_formats is available. (patchset #4 id:60001 of https://codereview.chromium.org/2693653002/ ) Reason for revert: This breaks: https://build.chromium.org/p/chromium.gpu/builders/Linux%20Debug%20%28NVIDIA%... Error from the output: [4533:4533:0307/120003.054303:1731388651:ERROR:gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc(647)] ApplyFramebufferAttachmentCMAAINTEL: shader compilation failed: GL_FRAGMENT_SHADER shader compilation failed: 0(1) : error C0000: syntax error, unexpected $undefined at token "<undefined>" 0(1) : error C0155: integer constant overflow 0(4) : warning C7022: unrecognized profile specifier "highp" 0(4) : warning C7022: unrecognized profile specifier "precision" Original issue's description: > cmaa, gpu: use R8 image texture when GL_NV_image_formats is available. > > Recently Mesa supports GL_NV_image_formats extension for r8 image texture for ES 3.1. > https://bugs.freedesktop.org/show_bug.cgi?id=98480 > So CMAA can use R8 texture, instead of RGBA8. > > In addition, CMAA implementation checks R8 support tests, and it slows down GPU > initialization. Remove all unnecessary tests and just check certain extensions. > > BUG=535198, 642290 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2693653002 > Cr-Commit-Position: refs/heads/master@{#455170} > Committed: https://chromium.googlesource.com/chromium/src/+/8d2609f6aa6f0a9f8ae238b8af06770337d726eb TBR=dongseong.hwang@chromium.org,piman@chromium.org,kbr@chromium.org,machenbach@chromium.org,dongseong.hwang@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=535198, 642290 Review-Url: https://codereview.chromium.org/2738213003 Cr-Commit-Position: refs/heads/master@{#455805} Committed: https://chromium.googlesource.com/chromium/src/+/870bce2d5e6ed3ba5d7b513b69d55fdb26efc2d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -58 lines) Patch
M gpu/command_buffer/service/feature_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 6 chunks +71 lines, -57 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Zhenyao Mo
Created Revert of cmaa, gpu: use R8 image texture when GL_NV_image_formats is available.
3 years, 9 months ago (2017-03-09 17:27:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738213003/1
3 years, 9 months ago (2017-03-09 17:27:23 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:40:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/870bce2d5e6ed3ba5d7b513b69d5...

Powered by Google App Engine
This is Rietveld 408576698