[serializer] check that deserializer read the entire blob.

[serializer] check that deserializer read the entire blob.

R=vogelheim@chromium.org
BUG=v8:6072
Review-Url: https://codereview.chromium.org/2738213002
Cr-Commit-Position: refs/heads/master@{#43697}
Committed: https://chromium.googlesource.com/v8/v8/+/21880a5357a13843489d3407b1afcde28ca9c191

[vogelheim1, 2017-03-09 12:17:42]

vogelheim@google.com changed reviewers:
+ vogelheim@google.com

[vogelheim1, 2017-03-09 12:17:42]

lgtm

[vogelheim, 2017-03-09 12:18:37]

vogelheim@chromium.org changed reviewers:
- vogelheim@google.com

[vogelheim, 2017-03-09 12:18:37]

lgtm

[vogelheim, 2017-03-09 12:21:27]

https://codereview.chromium.org/2738213002/diff/1/src/snapshot/deserializer.cc
File src/snapshot/deserializer.cc (right):

https://codereview.chromium.org/2738213002/diff/1/src/snapshot/deserializer.c...
src/snapshot/deserializer.cc:180: CHECK_EQ(kNop, next);
For my understanding: This loop is meant to compensate for Serializer::Pad() ?

[Yang, 2017-03-09 12:22:25]

https://codereview.chromium.org/2738213002/diff/1/src/snapshot/deserializer.cc
File src/snapshot/deserializer.cc (right):

https://codereview.chromium.org/2738213002/diff/1/src/snapshot/deserializer.c...
src/snapshot/deserializer.cc:180: CHECK_EQ(kNop, next);
On 2017/03/09 12:21:27, vogelheim wrote:
> For my understanding: This loop is meant to compensate for Serializer::Pad() ?

Yes.

[Yang, 2017-03-09 12:24:43]

Added comment.

[Yang, 2017-03-09 12:24:50]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-03-09 12:24:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@google.com, vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2738213002/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2017-03-09 12:25:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 13:39:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489062290809890,
"parent_rev": "99bdf971c873a103b48f0d4712f91222892980e3", "commit_rev":
"21880a5357a13843489d3407b1afcde28ca9c191"}

[commit-bot: I haz the power, 2017-03-09 13:39:25]

Description was changed from

==========
[serializer] check that deserializer read the entire blob.

R=vogelheim@chromium.org
BUG=v8:6072
==========

to

==========
[serializer] check that deserializer read the entire blob.

R=vogelheim@chromium.org
BUG=v8:6072

Review-Url: https://codereview.chromium.org/2738213002
Cr-Commit-Position: refs/heads/master@{#43697}
Committed:
https://chromium.googlesource.com/v8/v8/+/21880a5357a13843489d3407b1afcde28ca...
==========

[commit-bot: I haz the power, 2017-03-09 13:39:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/21880a5357a13843489d3407b1afcde28ca...