Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2738183002: [cc] Fix LayerTreeHostTestBeginFrameSequenceNumbers. (Closed)

Created:
3 years, 9 months ago by Eric Seckler
Modified:
3 years, 9 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cc] Fix LayerTreeHostTestBeginFrameSequenceNumbers flakiness. DrawLayersOnThread and DisplayReceivedCompositorFrameOnThread were being called for the second commit during shutdown of the test after EndTest(), causing the expectations within to fail. Added early outs. Also, DrawLayersOnThread is called after the draw has completed and, thus, after the compositor frame was submitted. Fixed the expected ordering in the test. BUG=699640 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2738183002 Cr-Commit-Position: refs/heads/master@{#456528} Committed: https://chromium.googlesource.com/chromium/src/+/d4b3ea55a73c7053a9591e1c0c6fba6e85e166da

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +18 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
Eric Seckler
Brian, can you have a look please?
3 years, 9 months ago (2017-03-09 11:18:02 UTC) #11
brianderson
lgtm
3 years, 9 months ago (2017-03-13 22:01:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738183002/100001
3 years, 9 months ago (2017-03-13 22:03:38 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:11:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d4b3ea55a73c7053a9591e1c0c6f...

Powered by Google App Engine
This is Rietveld 408576698