[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file
(keyboard, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=bshe@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2738173003
Cr-Commit-Position: refs/heads/master@{#460406}
Committed: https://chromium.googlesource.com/chromium/src/+/d095e93656b809a44931141e9c78399197c9ada4

[ymzhang1, 2017-03-09 23:22:12]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file
(keyboard, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=bshe@chromium.org
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file
(keyboard, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=bshe@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ymzhang1, 2017-03-09 23:23:44]

Patchset #1 (id:1) has been deleted

[ymzhang1, 2017-03-09 23:25:22]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

-Yangmuzi

[cjgrant, 2017-03-10 14:53:01]

cjgrant@chromium.org changed reviewers:
+ cjgrant@chromium.org

[cjgrant, 2017-03-10 14:53:02]

https://codereview.chromium.org/2738173003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/vr_shell/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/OWNERS:6: # COMPONENT: UI>Shell
The name vr_shell may be misleading in this sense.  The component should be
UI>Browser>VR

https://codereview.chromium.org/2738173003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/OWNERS:6: # COMPONENT: UI>Shell
UI>Browser>VR here as well.

[ymzhang1, 2017-03-10 18:10:17]

https://codereview.chromium.org/2738173003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/vr_shell/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/OWNERS:6: # COMPONENT: UI>Shell
On 2017/03/10 14:53:02, cjgrant wrote:
> The name vr_shell may be misleading in this sense.  The component should be
> UI>Browser>VR

Done. Thanks for letting me know!

https://codereview.chromium.org/2738173003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/OWNERS:6: # COMPONENT: UI>Shell
On 2017/03/10 14:53:02, cjgrant wrote:
> UI>Browser>VR here as well.
> 

Done.

[bshe, 2017-03-21 13:52:30]

bshe@chromium.org changed reviewers:
+ shuchen@chromium.org

[bshe, 2017-03-21 13:52:31]

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/wallpaper/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/OWNERS:4: # COMPONENT:
Services>Invalidation
I am not sure if Services>Invalidation applies here. The code is for integrating
wallpaper to login screen. We didn't create a component back then but reused
UI>Shell>Wallpaper
component name. In that sense, should this be UI>Shell>Wallpaper?

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/api/virtual_keyboard_private/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/virtual_keyboard_private/OWNERS:4: # COMPONENT:
IO>Keyboard
This is for virtual keyboard only, should this be UI>Input>VirtualKeyboard ?

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/wallpaper_manager/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/wallpaper_manager/OWNERS:4: # COMPONENT:
UI>ProximityAuth
same as chrome/browser/chromeos/login/users/wallpaper/OWNERS, should this be
UI>Shell>Wallpaper ?

https://codereview.chromium.org/2738173003/diff/60001/extensions/browser/api/...
File extensions/browser/api/virtual_keyboard/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/extensions/browser/api/...
extensions/browser/api/virtual_keyboard/OWNERS:5: # COMPONENT: IO>Keyboard
should this be UI>Input>VirtualKeyboard ?

https://codereview.chromium.org/2738173003/diff/60001/extensions/browser/api/...
File extensions/browser/api/virtual_keyboard_private/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/extensions/browser/api/...
extensions/browser/api/virtual_keyboard_private/OWNERS:4: # COMPONENT:
IO>Keyboard
ditto

https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
File third_party/google_input_tools/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
third_party/google_input_tools/OWNERS:9: # COMPONENT: UI>Input
The component should probably be UI>Input>Text>IME and the team is also not
correct.
+shuchen to comment on this one.

https://codereview.chromium.org/2738173003/diff/60001/ui/keyboard/OWNERS
File ui/keyboard/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/ui/keyboard/OWNERS#newc...
ui/keyboard/OWNERS:8: # COMPONENT: IO>Keyboard
This is for virtual keyboard window management. So UI>Input>VirtualKeyboard
makes more sense.

https://codereview.chromium.org/2738173003/diff/60001/ui/keyboard/resources/O...
File ui/keyboard/resources/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/ui/keyboard/resources/O...
ui/keyboard/resources/OWNERS:4: # COMPONENT: IO>Keyboard
ditto

[ymzhang1, 2017-03-21 17:00:35]

ymzhang@chromium.org changed reviewers:
- cjgrant@chromium.org

[ymzhang1, 2017-03-21 17:00:36]

Updated as suggested. 

+shuchen
Could you please help to review  third_party/google_input_tools/OWNERS and
suggest the team responsible for UI>Input>Text>IME? Thanks!

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/wallpaper/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/OWNERS:4: # COMPONENT:
Services>Invalidation
On 2017/03/21 13:52:31, bshe wrote:
> I am not sure if Services>Invalidation applies here. The code is for
integrating
> wallpaper to login screen. We didn't create a component back then but reused
> UI>Shell>Wallpaper
> component name. In that sense, should this be UI>Shell>Wallpaper?

Done.

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/api/virtual_keyboard_private/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/virtual_keyboard_private/OWNERS:4: # COMPONENT:
IO>Keyboard
On 2017/03/21 13:52:31, bshe wrote:
> This is for virtual keyboard only, should this be UI>Input>VirtualKeyboard ?

Done.

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/wallpaper_manager/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/wallpaper_manager/OWNERS:4: # COMPONENT:
UI>ProximityAuth
On 2017/03/21 13:52:31, bshe wrote:
> same as chrome/browser/chromeos/login/users/wallpaper/OWNERS, should this be
> UI>Shell>Wallpaper ?

Done.

https://codereview.chromium.org/2738173003/diff/60001/extensions/browser/api/...
File extensions/browser/api/virtual_keyboard/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/extensions/browser/api/...
extensions/browser/api/virtual_keyboard/OWNERS:5: # COMPONENT: IO>Keyboard
On 2017/03/21 13:52:31, bshe wrote:
> should this be UI>Input>VirtualKeyboard ?

Done.

https://codereview.chromium.org/2738173003/diff/60001/extensions/browser/api/...
File extensions/browser/api/virtual_keyboard_private/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/extensions/browser/api/...
extensions/browser/api/virtual_keyboard_private/OWNERS:4: # COMPONENT:
IO>Keyboard
On 2017/03/21 13:52:31, bshe wrote:
> ditto

Done.

https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
File third_party/google_input_tools/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
third_party/google_input_tools/OWNERS:9: # COMPONENT: UI>Input
On 2017/03/21 13:52:31, bshe wrote:
> The component should probably be UI>Input>Text>IME and the team is also not
> correct.
> +shuchen to comment on this one.

Done.

https://codereview.chromium.org/2738173003/diff/60001/ui/keyboard/OWNERS
File ui/keyboard/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/ui/keyboard/OWNERS#newc...
ui/keyboard/OWNERS:8: # COMPONENT: IO>Keyboard
On 2017/03/21 13:52:31, bshe wrote:
> This is for virtual keyboard window management. So UI>Input>VirtualKeyboard
> makes more sense.

Done.

https://codereview.chromium.org/2738173003/diff/60001/ui/keyboard/resources/O...
File ui/keyboard/resources/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/ui/keyboard/resources/O...
ui/keyboard/resources/OWNERS:4: # COMPONENT: IO>Keyboard
On 2017/03/21 13:52:31, bshe wrote:
> ditto

Done.

[Shu Chen, 2017-03-29 00:38:59]

https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
File third_party/google_input_tools/OWNERS (right):

https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
third_party/google_input_tools/OWNERS:9: # COMPONENT: UI>Input
On 2017/03/21 17:00:36, ymzhang1 wrote:
> On 2017/03/21 13:52:31, bshe wrote:
> > The component should probably be UI>Input>Text>IME and the team is also not
> > correct.
> > +shuchen to comment on this one.
> 
> Done.

lgtm.

[bshe, 2017-03-29 15:19:34]

On 2017/03/29 00:38:59, Shu Chen wrote:
>
https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
> File third_party/google_input_tools/OWNERS (right):
> 
>
https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
> third_party/google_input_tools/OWNERS:9: # COMPONENT: UI>Input
> On 2017/03/21 17:00:36, ymzhang1 wrote:
> > On 2017/03/21 13:52:31, bshe wrote:
> > > The component should probably be UI>Input>Text>IME and the team is also
not
> > > correct.
> > > +shuchen to comment on this one.
> > 
> > Done.
> 
> lgtm.

lgtm2

[bshe, 2017-03-29 15:20:01]

On 2017/03/29 15:19:34, bshe wrote:
> On 2017/03/29 00:38:59, Shu Chen wrote:
> >
>
https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
> > File third_party/google_input_tools/OWNERS (right):
> > 
> >
>
https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
> > third_party/google_input_tools/OWNERS:9: # COMPONENT: UI>Input
> > On 2017/03/21 17:00:36, ymzhang1 wrote:
> > > On 2017/03/21 13:52:31, bshe wrote:
> > > > The component should probably be UI>Input>Text>IME and the team is also
> not
> > > > correct.
> > > > +shuchen to comment on this one.
> > > 
> > > Done.
> > 
> > lgtm.
> 
> lgtm2

hmm, proper lgtm

[ymzhang1, 2017-03-29 15:38:39]

On 2017/03/29 15:20:01, bshe wrote:
> On 2017/03/29 15:19:34, bshe wrote:
> > On 2017/03/29 00:38:59, Shu Chen wrote:
> > >
> >
>
https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
> > > File third_party/google_input_tools/OWNERS (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2738173003/diff/60001/third_party/google_inpu...
> > > third_party/google_input_tools/OWNERS:9: # COMPONENT: UI>Input
> > > On 2017/03/21 17:00:36, ymzhang1 wrote:
> > > > On 2017/03/21 13:52:31, bshe wrote:
> > > > > The component should probably be UI>Input>Text>IME and the team is
also
> > not
> > > > > correct.
> > > > > +shuchen to comment on this one.
> > > > 
> > > > Done.
> > > 
> > > lgtm.
> > 
> > lgtm2
> 
> hmm, proper lgtm

^.^ thanks!

[ymzhang1, 2017-03-29 15:38:45]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:39:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 16:08:30]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490801925511780,
"parent_rev": "68b9ec68fc7709b47a66fe10320b64c5b008e79d", "commit_rev":
"d095e93656b809a44931141e9c78399197c9ada4"}

[commit-bot: I haz the power, 2017-03-29 16:09:16]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file
(keyboard, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=bshe@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file
(keyboard, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=bshe@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2738173003
Cr-Commit-Position: refs/heads/master@{#460406}
Committed:
https://chromium.googlesource.com/chromium/src/+/d095e93656b809a44931141e9c78...
==========

[commit-bot: I haz the power, 2017-03-29 16:09:17]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d095e93656b809a44931141e9c78...