third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 2738163002: Enable CopyTextureCHROMIUM in Blink for Tex{Sub}Image2D with more cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 2738163002: Enable CopyTextureCHROMIUM in Blink for Tex{Sub}Image2D with more cases (Closed)

Patch Set: enable fallback path Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/gpu/gpu_tests/webgl_conformance_expectations.py ('K') | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index fb2455a468cefcd196f7531c345a51ffd8fbf2af..0756c6125e83fbb89e2f06e730a120038467e0f8 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -1101,16 +1101,12 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

WebGLTexture*,

GLenum target,

GLint level,

- GLint internalformat,

- GLenum type,

GLint xoffset,

GLint yoffset,

GLint zoffset,

CanvasImageSource*,

const IntRect& sourceSubRectangle);

- virtual bool canUseTexImageByGPU(TexImageFunctionID,

- GLint internalformat,

- GLenum type);

+ virtual bool canUseTexImageByGPU(GLenum type);

virtual WebGLImageConversion::PixelStoreParams getPackPixelStoreParams();

virtual WebGLImageConversion::PixelStoreParams getUnpackPixelStoreParams(

@@ -1645,14 +1641,18 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

unsigned);

void texImageCanvasByGPU(TexImageFunctionID,

HTMLCanvasElement*,

- GLuint,

- GLenum,

GLenum,

+ GLuint,

GLint,

+ const IntRect&);

+ void texImageBitmapByGPU(ImageBitmap*,

+ GLenum,

+ GLuint,

+ bool,

+ GLint,

GLint,

- const IntRect& sourceSubRectangle);

- void texImageBitmapByGPU(ImageBitmap*, GLuint, GLenum, GLenum, GLint, bool);

+ const IntRect&);

sk_sp<SkImage> makeImageSnapshot(SkImageInfo&);

const unsigned m_version;