Enable CopyTextureCHROMIUM in Blink for Tex{Sub}Image2D with more cases

content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Index: content/test/gpu/gpu_tests/webgl_conformance_expectations.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
index 0463383e5f4b85389a6b1806055935cf7744df57..b6e79c8f1ee26f5d68d7a07eca4bb86d21230698 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
@@ -99,7 +99,7 @@ class WebGLConformanceExpectations(GpuTestExpectations):
     # We need to add WebGL 1 check in command buffer that format/type from
     # TexSubImage2D have to match the current texture's.
     self.Fail('conformance/textures/misc/tex-sub-image-2d-bad-args.html',
-        bug=570453)
+        bug=625738)
 
     # Passthrough command decoder
     self.Fail('conformance/extensions/ext-sRGB.html',
@@ -160,6 +160,22 @@ class WebGLConformanceExpectations(GpuTestExpectations):
         ['passthrough'], bug=1523) # angle bug ID
     self.Fail('WebglExtension_WEBGL_draw_buffers',
         ['passthrough'], bug=1523) # angle bug ID
+    self.Skip('conformance/textures/canvas/*',
+        ['passthrough'], bug=1932) # angle bug ID
+    self.Skip('conformance/textures/video/*',
+        ['passthrough'], bug=1932) # angle bug ID
+    self.Skip('conformance/textures/image_bitmap_from_canvas/*',
+        ['passthrough'], bug=1932) # angle bug ID
+    self.Skip('conformance/textures/webgl_canvas/*',
+        ['passthrough'], bug=1932) # angle bug ID
+    self.Skip('conformance/extensions/oes-texture-half-float-with-canvas.html',
+        ['passthrough'], bug=1932) # angle bug ID
+    self.Skip('conformance/extensions/oes-texture-float-with-canvas.html',
+        ['passthrough'], bug=1932) # angle bug ID
+    self.Skip('conformance/extensions/oes-texture-half-float-with-video.html',
+        ['passthrough'], bug=1932) # angle bug ID
+    self.Skip('conformance/extensions/oes-texture-float-with-video.html',
+        ['passthrough'], bug=1932) # angle bug ID

[Ken Russell (switch to Gerrit), 2017/04/01 01:13:26]

These broad new skip entries are concerning, because we've been making a lot of
progress on the pass-through command buffer to this point. What work needs to be
done in the pass-through command buffer (or ANGLE) to make them pass?

[qiankun, 2017/04/05 08:43:14]

I saw Geoff already landed two patches to update glCopyTextureCHROMIUM entry
point in ANGLE and chromium passthrough path. But these tests are still failing
with passthrough path, see try-bots in patch set#7. I saw at least two
NOTIMPLEMENTED() crashes: Error
GLES2DecoderPassthroughImpl::DoTraceBeginCHROMIUM and
GLES2DecoderPassthroughImpl::DoFlushDriverCachesCHROMIUM.

[Geoff Lang, 2017/04/05 14:11:12]

So far I've only updated the bindings to the new function prototypes but haven't
added support for any of the new features.

The NOTIMPLEMENTED are expected.

I think these failures are OK until we implement the new features in ANGLE's
CHROMIUM_copy_texture

 
     # Passthrough command decoder / OpenGL
     self.Fail('conformance/buffers/buffer-uninitialized.html',
@@ -434,19 +450,19 @@ class WebGLConformanceExpectations(GpuTestExpectations):
     # Linux failures
     self.Flaky('conformance/textures/video/' +
                'tex-2d-rgba-rgba-unsigned_byte.html',
-               ['linux'], bug=627525)
+               ['linux', 'no_passthrough'], bug=627525)
     self.Flaky('conformance/textures/video/' +
                'tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html',
-               ['linux'], bug=627525)
+               ['linux', 'no_passthrough'], bug=627525)
     self.Flaky('conformance/textures/video/' +
                'tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html',
-               ['linux'], bug=627525)
+               ['linux', 'no_passthrough'], bug=627525)
     self.Flaky('conformance/textures/video/' +
                'tex-2d-rgb-rgb-unsigned_byte.html',
-               ['linux'], bug=627525)
+               ['linux', 'no_passthrough'], bug=627525)
     self.Flaky('conformance/textures/video/' +
                'tex-2d-rgb-rgb-unsigned_short_5_6_5.html',
-               ['linux'], bug=627525)
+               ['linux', 'no_passthrough'], bug=627525)
     self.Fail('conformance/extensions/webgl-compressed-texture-astc.html',
         ['linux', 'intel'], bug=680675)