Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2738153003: [parser] Make reusable_preparser really reusable (Closed)

Created:
3 years, 9 months ago by wiktorg
Modified:
3 years, 9 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Make reusable_preparser really reusable BUG= R=marja@chromium.org Review-Url: https://codereview.chromium.org/2738153003 Cr-Commit-Position: refs/heads/master@{#43716} Committed: https://chromium.googlesource.com/v8/v8/+/61a8954eae68f74e254d0b831929a2c6676aa2be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M src/parsing/parser.h View 1 chunk +20 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738153003/1
3 years, 9 months ago (2017-03-09 10:18:24 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-09 10:18:26 UTC) #6
marja
lgtm
3 years, 9 months ago (2017-03-09 10:26:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738153003/1
3 years, 9 months ago (2017-03-10 09:15:17 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 09:17:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/61a8954eae68f74e254d0b831929a2c6676...

Powered by Google App Engine
This is Rietveld 408576698