Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 2738143002: Fix fetch-event-redirect.https.html layout test using promise_test (Closed)

Created:
3 years, 9 months ago by horo
Modified:
3 years, 9 months ago
Reviewers:
falken
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix fetch-event-redirect.https.html layout test using promise_test This test is crashing on Debug build because of OOM. This CL changes the test to use promise_test instead of async_test inorder not to start multiple service workers in parallel. BUG=698872 Review-Url: https://codereview.chromium.org/2738143002 Cr-Commit-Position: refs/heads/master@{#455680} Committed: https://chromium.googlesource.com/chromium/src/+/35a17d3593ecde3b7cea1ad36ada111d659b974a

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix rebase error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -113 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-redirect.https.html View 55 chunks +109 lines, -109 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
horo
falken@ Could you please review this?
3 years, 9 months ago (2017-03-09 05:21:10 UTC) #9
falken
lgtm, nice
3 years, 9 months ago (2017-03-09 05:27:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738143002/40001
3 years, 9 months ago (2017-03-09 05:29:27 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 06:26:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/35a17d3593ecde3b7cea1ad36ada...

Powered by Google App Engine
This is Rietveld 408576698