Promotes a handful of members from WmShell to Shell

Promotes a handful of members from WmShell to Shell

This is the set of objects created by what was WmShell::Initialize().

BUG=687660
TEST=covered by tests
R=msw@chromium.org, sadrul@chromium.org, elijahtaylor@chromium.org, reveman@chromium.org
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2738133003
Cr-Commit-Position: refs/heads/master@{#455910}
Committed: https://chromium.googlesource.com/chromium/src/+/07a24d4e93c52240de9d3dd799657e976c64df7a

[sky, 2017-03-09 18:46:14]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 18:46:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-09 18:47:11]

Description was changed from

==========
Promotes a handful of members from WmShell to Shell

This is the set of objects created by what was WmShell::Initialize().

BUG=687660
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Promotes a handful of members from WmShell to Shell

This is the set of objects created by what was WmShell::Initialize().

BUG=687660
TEST=covered by tests
R=msw@chromium.org, sadrul@chromium.org, elijahtaylor@chromium.org,
reveman@chromium.org
==========

[sky, 2017-03-09 18:47:12]

sky@chromium.org changed reviewers:
+ elijahtaylor@chromium.org, reveman@chromium.org, sadrul@chromium.org

[commit-bot: I haz the power, 2017-03-09 18:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 18:59:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-03-09 20:09:21]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 20:09:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 20:23:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 20:23:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-03-09 20:51:47]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 20:52:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-09 20:52:45]

sadrul: DEPS change (ash/ needs to depend upon components/ui_devtools rather
than ash/common)
reveman: exo
elijahtaylor1: arc
msw: the rest (sorry)

[commit-bot: I haz the power, 2017-03-09 21:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 21:29:00]

Dry run: This issue passed the CQ dry run.

[msw, 2017-03-09 21:57:20]

lgtm with nits/qs/aside.

https://codereview.chromium.org/2738133003/diff/40001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2738133003/diff/40001/ash/shell.h#newcode541
ash/shell.h:541: std::unique_ptr<AccessibilityDelegate> accessibility_delegate_;
aside: the abc ordering in this file is all kinds of crazy. SAD! :)

https://codereview.chromium.org/2738133003/diff/40001/ash/test/shell_test_api.cc
File ash/test/shell_test_api.cc (right):

https://codereview.chromium.org/2738133003/diff/40001/ash/test/shell_test_api...
ash/test/shell_test_api.cc:6: #include "ash/common/palette_delegate.h"
q: can we skip this for just assigning/moving the unique_ptr?

https://codereview.chromium.org/2738133003/diff/40001/ash/test/shell_test_api.h
File ash/test/shell_test_api.h (right):

https://codereview.chromium.org/2738133003/diff/40001/ash/test/shell_test_api...
ash/test/shell_test_api.h:29: explicit ShellTestApi(Shell* shell);
This is always called with Shell::GetInstance(), perhaps we should remove it and
the |shell_| member (in a follow-up CL)?

https://codereview.chromium.org/2738133003/diff/40001/components/exo/shell_su...
File components/exo/shell_surface_unittest.cc (right):

https://codereview.chromium.org/2738133003/diff/40001/components/exo/shell_su...
components/exo/shell_surface_unittest.cc:5: #include
"components/exo/shell_surface.h"
nit: blank line after?

[elijahtaylor1, 2017-03-09 21:59:45]

arc/* LGTM

[sadrul, 2017-03-09 23:16:40]

lgtm

[sky, 2017-03-09 23:20:32]

Description was changed from

==========
Promotes a handful of members from WmShell to Shell

This is the set of objects created by what was WmShell::Initialize().

BUG=687660
TEST=covered by tests
R=msw@chromium.org, sadrul@chromium.org, elijahtaylor@chromium.org,
reveman@chromium.org
==========

to

==========
Promotes a handful of members from WmShell to Shell

This is the set of objects created by what was WmShell::Initialize().

BUG=687660
TEST=covered by tests
R=msw@chromium.org, sadrul@chromium.org, elijahtaylor@chromium.org,
reveman@chromium.org
TBR=reveman@chromium.org
==========

[sky, 2017-03-09 23:20:42]

TBR reveman for trivial change

[sky, 2017-03-09 23:20:47]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:21:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 23:57:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489101647608920,
"parent_rev": "816c1c01dce669bd39ab3c3f769a9af8ee7a7e05", "commit_rev":
"07a24d4e93c52240de9d3dd799657e976c64df7a"}

[commit-bot: I haz the power, 2017-03-09 23:58:19]

Description was changed from

==========
Promotes a handful of members from WmShell to Shell

This is the set of objects created by what was WmShell::Initialize().

BUG=687660
TEST=covered by tests
R=msw@chromium.org, sadrul@chromium.org, elijahtaylor@chromium.org,
reveman@chromium.org
TBR=reveman@chromium.org
==========

to

==========
Promotes a handful of members from WmShell to Shell

This is the set of objects created by what was WmShell::Initialize().

BUG=687660
TEST=covered by tests
R=msw@chromium.org, sadrul@chromium.org, elijahtaylor@chromium.org,
reveman@chromium.org
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2738133003
Cr-Commit-Position: refs/heads/master@{#455910}
Committed:
https://chromium.googlesource.com/chromium/src/+/07a24d4e93c52240de9d3dd79965...
==========

[commit-bot: I haz the power, 2017-03-09 23:58:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/07a24d4e93c52240de9d3dd79965...

[reveman, 2017-03-10 02:09:21]

lgtm