third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp - Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient. (Closed)

Patch Set: Add a derived WebViewClient and use it when no client is passed. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

index 3135c41469973049a984e8b5e991e2205798430b..fa298977e82b7ecac5be550db97b636ccc7a73a4 100644

--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

@@ -292,7 +292,7 @@ void WebEmbeddedWorkerImpl::prepareShadowPageForLoader() {

// This code, and probably most of the code in this class should be shared

// with SharedWorker.

DCHECK(!m_webView);

- m_webView = WebView::create(nullptr, WebPageVisibilityStateVisible);

+ m_webView = WebView::create(WebPageVisibilityStateVisible);

WebSettings* settings = m_webView->settings();

// FIXME: http://crbug.com/363843. This needs to find a better way to

// not create graphics layers.