media/blink/webmediaplayer_impl_unittest.cc - Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient. (Closed)

Patch Set: Add a derived WebViewClient and use it when no client is passed. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_impl_unittest.cc

diff --git a/media/blink/webmediaplayer_impl_unittest.cc b/media/blink/webmediaplayer_impl_unittest.cc

index 5eb1a8d74bbaab28ed0c6d5cc8bfc56ed7ab4c6c..bea8c5ca35fed6c302a686ae78a7cf0e2426c96a 100644

--- a/media/blink/webmediaplayer_impl_unittest.cc

+++ b/media/blink/webmediaplayer_impl_unittest.cc

@@ -188,8 +188,7 @@ class WebMediaPlayerImplTest : public testing::Test {

public:

WebMediaPlayerImplTest()

: media_thread_("MediaThreadForTest"),

- web_view_(blink::WebView::create(nullptr,

- blink::WebPageVisibilityStateVisible)),

+ web_view_(blink::WebView::create(blink::WebPageVisibilityStateVisible)),

web_local_frame_(

blink::WebLocalFrame::create(blink::WebTreeScopeType::Document,

&web_frame_client_,