media/blink/multibuffer_data_source_unittest.cc - Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/multibuffer_data_source_unittest.cc

Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient. (Closed)

Patch Set: Add a derived WebViewClient and use it when no client is passed. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/multibuffer_data_source_unittest.cc

diff --git a/media/blink/multibuffer_data_source_unittest.cc b/media/blink/multibuffer_data_source_unittest.cc

index 993aa921a1e913d7b466a669fc6056e59ea9953a..1c70641cf4301af35824963aa77a7fcd61a2d2e1 100644

--- a/media/blink/multibuffer_data_source_unittest.cc

+++ b/media/blink/multibuffer_data_source_unittest.cc

@@ -225,7 +225,7 @@ static const char kHttpDifferentOriginUrl[] = "http://127.0.0.1/foo.webm";

class MultibufferDataSourceTest : public testing::Test {

public:

MultibufferDataSourceTest()

- : view_(WebView::create(nullptr, blink::WebPageVisibilityStateVisible)),

+ : view_(WebView::create(blink::WebPageVisibilityStateVisible)),

preload_(MultibufferDataSource::AUTO) {

WebLocalFrame* frame = WebLocalFrame::create(

blink::WebTreeScopeType::Document, &client_, nullptr, nullptr);