extensions/renderer/scoped_web_frame.cc - Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/scoped_web_frame.cc

Issue 2738133002: Provide an overload to WebView::create that does not require a WebViewClient. (Closed)

Patch Set: Add a derived WebViewClient and use it when no client is passed. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/scoped_web_frame.cc

diff --git a/extensions/renderer/scoped_web_frame.cc b/extensions/renderer/scoped_web_frame.cc

index 2a7e37a220d9f2571911fd2297fea9148bd03b72..a1ecc9e68442fb5e276bcec4136725ec5f48f819 100644

--- a/extensions/renderer/scoped_web_frame.cc

+++ b/extensions/renderer/scoped_web_frame.cc

@@ -9,7 +9,7 @@

namespace extensions {

ScopedWebFrame::ScopedWebFrame() : view_(nullptr), frame_(nullptr) {

- view_ = blink::WebView::create(nullptr, blink::WebPageVisibilityStateVisible);

+ view_ = blink::WebView::create(blink::WebPageVisibilityStateVisible);

frame_ = blink::WebLocalFrame::create(blink::WebTreeScopeType::Document,

&frame_client_, nullptr, nullptr);

view_->setMainFrame(frame_);