Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2738113003: Revert of Improve performance of GeometryMapper cache. (Closed)

Created:
3 years, 9 months ago by Michael Achenbach
Modified:
3 years, 9 months ago
Reviewers:
pdr., Xianzhu, chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, Henrik Grunell, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve performance of GeometryMapper cache. (patchset #39 id:690001 of https://codereview.chromium.org/2729243002/ ) Reason for revert: Breaks msan: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/781 Original issue's description: > Improve performance of GeometryMapper cache. > > 1. Store clips and transforms in vectors attached to the clip and transform nodes. > This avoids all hash map lookups. Invalidation uses a global cache generation id > (currently we don't support anything other than global invalidation of the > GeometryMapper caches). > > 2. Return clips and transforms by reference, to avoid copying. > > #1 is expected to be a good optimization because we almost always compute clips > and transforms relative to the same ancestor, so the vectors are short and hash > lookups are reduced. > > BUG=692614 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2729243002 > Cr-Commit-Position: refs/heads/master@{#455571} > Committed: https://chromium.googlesource.com/chromium/src/+/ee72c4b5d2fd1e4882bddca66e0f89fe8784a7fc TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692614 Review-Url: https://codereview.chromium.org/2738113003 Cr-Commit-Position: refs/heads/master@{#455706} Committed: https://chromium.googlesource.com/chromium/src/+/b0ef4258b2832480c9086fac69210b3338a38198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -330 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h View 3 chunks +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h View 2 chunks +36 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 9 chunks +51 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/GeometryMapperClipCache.h View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/GeometryMapperClipCache.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 4 chunks +23 lines, -27 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTransformCache.h View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTransformCache.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Improve performance of GeometryMapper cache.
3 years, 9 months ago (2017-03-09 09:12:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738113003/1
3 years, 9 months ago (2017-03-09 09:13:08 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 09:14:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b0ef4258b2832480c9086fac6921...

Powered by Google App Engine
This is Rietveld 408576698