Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2738093002: Use the correct observer in TabThemeTest (Closed)

Created:
3 years, 9 months ago by wychen
Modified:
3 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct observer in TabThemeTest It's flaky without this fix, and the probability of failing would be much higher if PlzNavigate is enabled. BUG=699380 Review-Url: https://codereview.chromium.org/2738093002 Cr-Commit-Position: refs/heads/master@{#455849} Committed: https://chromium.googlesource.com/chromium/src/+/b7d65eda07d21cff0513ba84c90fc9b29fa53577

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/TabThemeTest.java View 4 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
wychen
PTAL. The CL dependency is for the try-bots to get plznavigate. It'll be removed.
3 years, 9 months ago (2017-03-09 00:18:48 UTC) #2
gone
lgtm
3 years, 9 months ago (2017-03-09 19:16:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738093002/40001
3 years, 9 months ago (2017-03-09 19:38:20 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 20:18:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b7d65eda07d21cff0513ba84c90f...

Powered by Google App Engine
This is Rietveld 408576698