WebUI: Polymer config tweaks for better performance.

WebUI: Polymer config tweaks for better performance.

Results in 5% improvement in startup JS scripting time for MD Settings. 


BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2738063008
Cr-Commit-Position: refs/heads/master@{#457184}
Committed: https://chromium.googlesource.com/chromium/src/+/a46bc7937ac5efb5d990fb5c49c519b21e037403

[dpapad, 2017-03-10 21:51:56]

Description was changed from

==========
DO NOT SUBMIT: Trying Polymer config tweaks for performance.
==========

to

==========
DO NOT SUBMIT: Trying Polymer config tweaks for performance.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-10 21:52:11]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 21:52:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 22:01:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 22:01:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dpapad, 2017-03-13 21:19:34]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 21:20:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 21:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 21:31:13]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dpapad, 2017-03-14 19:18:56]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 19:19:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 19:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:29:22]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dpapad, 2017-03-15 17:30:59]

Description was changed from

==========
DO NOT SUBMIT: Trying Polymer config tweaks for performance.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Polymer config tweaks for better performance.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-15 17:32:30]

Description was changed from

==========
WebUI: Polymer config tweaks for better performance.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Polymer config tweaks for better performance.

Results in 5% improvement in startup JS scripting time for MD Settings. 


BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-15 17:34:22]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-03-15 17:34:22]

Green tests on patch 3.

I have based this CL on top of Steven's crrev.com/2731403005, which is LGed, but
not landed yet. I'll rebase once it lands.

[Dan Beam, 2017-03-15 18:10:13]

lgtm

https://codereview.chromium.org/2738063008/diff/60001/ui/webui/resources/js/p...
File ui/webui/resources/js/polymer_config.js (right):

https://codereview.chromium.org/2738063008/diff/60001/ui/webui/resources/js/p...
ui/webui/resources/js/polymer_config.js:12: suppressTemplateNotifications: true,
nit: alpha

[dpapad, 2017-03-15 18:20:53]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 18:21:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-03-15 18:28:18]

https://codereview.chromium.org/2738063008/diff/60001/ui/webui/resources/js/p...
File ui/webui/resources/js/polymer_config.js (right):

https://codereview.chromium.org/2738063008/diff/60001/ui/webui/resources/js/p...
ui/webui/resources/js/polymer_config.js:12: suppressTemplateNotifications: true,
On 2017/03/15 at 18:10:13, Dan Beam wrote:
> nit: alpha

Done.

[commit-bot: I haz the power, 2017-03-15 19:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 19:39:23]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-03-15 19:49:31]

https://codereview.chromium.org/2738063008/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2738063008/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:114:
if="[[showDoNotTrackDialog_]]" notify-dom-change>
stevenjb

[dpapad, 2017-03-15 20:03:09]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-03-15 20:03:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2738063008/#ps80001
(title: "Rebase + comment.")

[commit-bot: I haz the power, 2017-03-15 20:03:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 20:18:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489608189826700,
"parent_rev": "99567cf4a49bc6e5b58b58ca3ace741194f08a8e", "commit_rev":
"a46bc7937ac5efb5d990fb5c49c519b21e037403"}

[commit-bot: I haz the power, 2017-03-15 20:19:13]

Description was changed from

==========
WebUI: Polymer config tweaks for better performance.

Results in 5% improvement in startup JS scripting time for MD Settings. 


BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Polymer config tweaks for better performance.

Results in 5% improvement in startup JS scripting time for MD Settings. 


BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2738063008
Cr-Commit-Position: refs/heads/master@{#457184}
Committed:
https://chromium.googlesource.com/chromium/src/+/a46bc7937ac5efb5d990fb5c49c5...
==========

[commit-bot: I haz the power, 2017-03-15 20:19:14]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a46bc7937ac5efb5d990fb5c49c5...