Activate keychain reauthorization.

Activate keychain reauthorization.

Activate the keychain reauthorization. Reauthorization will be performed
if the users preferences (cfprefs) indicate that the operation has been
attempted less than 2 times previously, and that the operation has not
previously succeeded. The number of attempts is set before the
operation, so that a crashy operation stops running after a finite
number of attempts. After successful completion, the preferences are
updated so that the operation is never run again. This CL also updates
the designated requirement with a new hash.

BUG=629906
Review-Url: https://codereview.chromium.org/2738053007
Cr-Commit-Position: refs/heads/master@{#456122}
Committed: https://chromium.googlesource.com/chromium/src/+/26eeef0331eabc5b5da2b02dd9f4ce6af731eac9

[Greg K, 2017-03-09 23:54:15]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[Greg K, 2017-03-09 23:54:42]

Description was changed from

==========
Activate keychain reauthorization.

Activate the keychain reauthorization. Reauthorization will be performed
if the users preferences (cfprefs) indicate that the operation has been
attempted less than 2 times previously, and that the operation has not
previously succeeded. The number of attempts is set before the
operation, so that a crashy operation stops running after a finite
number of attempts. After successful completion, the preferences are
updated so that the operation is never run again. This CL also updates
the designated requirement with a new hash.

BUG=629906
==========

to

==========
Activate keychain reauthorization.

Activate the keychain reauthorization. Reauthorization will be performed
if the users preferences (cfprefs) indicate that the operation has been
attempted less than 2 times previously, and that the operation has not
previously succeeded. The number of attempts is set before the
operation, so that a crashy operation stops running after a finite
number of attempts. After successful completion, the preferences are
updated so that the operation is never run again. This CL also updates
the designated requirement with a new hash.

BUG=629906
==========

[Greg K, 2017-03-09 23:54:43]

kerrnel@chromium.org changed reviewers:
+ mcolbert@chromium.org

[Greg K, 2017-03-09 23:54:52]

kerrnel@chromium.org changed reviewers:
+ mark@chromium.org
- mcolbert@chromium.org

[Greg K, 2017-03-09 23:55:09]

On 2017/03/09 23:54:52, Greg K wrote:
> mailto:kerrnel@chromium.org changed reviewers:
> + mailto:mark@chromium.org
> - mailto:mcolbert@chromium.org

Mark,

PTAL.

Thanks,

Greg

[commit-bot: I haz the power, 2017-03-09 23:55:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-03-10 00:56:46]

LGTM! LGTM LGTM LGTM

https://codereview.chromium.org/2738053007/diff/1/chrome/installer/mac/sign_a...
File chrome/installer/mac/sign_app.sh.in (right):

https://codereview.chromium.org/2738053007/diff/1/chrome/installer/mac/sign_a...
chrome/installer/mac/sign_app.sh.in:50: (identifier \"com.google.Chrome\" or
identifier \"com.google.Chrome.canary\") \
Since we’ve got to do the reauthorization now anyway, let’s expand this a bit to
avoid a potential reauthorization in the future, for when we split other
channels out for side-by-side installation (if we do that).

(identifier \"com.google.Chrome\" or \
identifier \"com.google.Chrome.beta\" or \
identifier \"com.google.Chrome.dev\" or \
identifier \"com.google.Chrome.canary\") and \
(certificate leaf = H\"85cee8254216185620ddc8851c7a9fc4dfe120ef\" or \
certificate leaf = H\"c9a99324ca3fcb23dbcc36bd5fd4f9753305130a\")

[commit-bot: I haz the power, 2017-03-10 00:58:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 00:58:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Greg K, 2017-03-10 18:06:07]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[Greg K, 2017-03-10 18:06:29]

https://codereview.chromium.org/2738053007/diff/1/chrome/installer/mac/sign_a...
File chrome/installer/mac/sign_app.sh.in (right):

https://codereview.chromium.org/2738053007/diff/1/chrome/installer/mac/sign_a...
chrome/installer/mac/sign_app.sh.in:50: (identifier \"com.google.Chrome\" or
identifier \"com.google.Chrome.canary\") \
On 2017/03/10 00:56:46, Mark Mentovai wrote:
> Since we’ve got to do the reauthorization now anyway, let’s expand this a bit
to
> avoid a potential reauthorization in the future, for when we split other
> channels out for side-by-side installation (if we do that).
> 
> (identifier \"com.google.Chrome\" or \
> identifier \"com.google.Chrome.beta\" or \
> identifier \"com.google.Chrome.dev\" or \
> identifier \"com.google.Chrome.canary\") and \
> (certificate leaf = H\"85cee8254216185620ddc8851c7a9fc4dfe120ef\" or \
> certificate leaf = H\"c9a99324ca3fcb23dbcc36bd5fd4f9753305130a\")

Done.

[commit-bot: I haz the power, 2017-03-10 18:06:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-03-10 18:10:19]

LGTM

[commit-bot: I haz the power, 2017-03-10 18:56:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:56:16]

Dry run: This issue passed the CQ dry run.

[Greg K, 2017-03-10 18:56:58]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:57:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 19:03:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489172218749530,
"parent_rev": "bee49a23fbe4ce847798aa87dff47440b07c097b", "commit_rev":
"26eeef0331eabc5b5da2b02dd9f4ce6af731eac9"}

[commit-bot: I haz the power, 2017-03-10 19:04:48]

Description was changed from

==========
Activate keychain reauthorization.

Activate the keychain reauthorization. Reauthorization will be performed
if the users preferences (cfprefs) indicate that the operation has been
attempted less than 2 times previously, and that the operation has not
previously succeeded. The number of attempts is set before the
operation, so that a crashy operation stops running after a finite
number of attempts. After successful completion, the preferences are
updated so that the operation is never run again. This CL also updates
the designated requirement with a new hash.

BUG=629906
==========

to

==========
Activate keychain reauthorization.

Activate the keychain reauthorization. Reauthorization will be performed
if the users preferences (cfprefs) indicate that the operation has been
attempted less than 2 times previously, and that the operation has not
previously succeeded. The number of attempts is set before the
operation, so that a crashy operation stops running after a finite
number of attempts. After successful completion, the preferences are
updated so that the operation is never run again. This CL also updates
the designated requirement with a new hash.

BUG=629906

Review-Url: https://codereview.chromium.org/2738053007
Cr-Commit-Position: refs/heads/master@{#456122}
Committed:
https://chromium.googlesource.com/chromium/src/+/26eeef0331eabc5b5da2b02dd9f4...
==========

[commit-bot: I haz the power, 2017-03-10 19:04:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/26eeef0331eabc5b5da2b02dd9f4...