Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2738043004: Relocate display_snapshot_mojo (Closed)

Created:
3 years, 9 months ago by rjkroege
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, Daniel Erat
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relocate display_snapshot_mojo Keeping DisplaySnapshotMojo in display/types enables tighter use of DEPS in ozone/platform/drm so relocate it appropriately. BUG=620927 Review-Url: https://codereview.chromium.org/2738043004 Cr-Commit-Position: refs/heads/master@{#456235} Committed: https://chromium.googlesource.com/chromium/src/+/dccc4a73c2b74721e6b7f5ef32859ea84e73603c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -118 lines) Patch
M ui/display/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/display/display_snapshot_mojo.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/display/display_snapshot_mojo.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M ui/display/mojo/display_snapshot_mojo.typemap View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/mojo/display_snapshot_mojo_struct_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/mojo/display_struct_traits_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/types/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/display/types/display_snapshot_mojo.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/display/types/display_snapshot_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
rjkroege
ptal.
3 years, 9 months ago (2017-03-09 21:32:55 UTC) #2
Daniel Erat
lgtm
3 years, 9 months ago (2017-03-09 21:40:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738043004/1
3 years, 9 months ago (2017-03-10 15:03:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/382839)
3 years, 9 months ago (2017-03-10 15:09:02 UTC) #7
rjkroege
tsepez@ for security review. This CL merely moves some code.
3 years, 9 months ago (2017-03-10 23:51:46 UTC) #9
Tom Sepez
RS LGTM
3 years, 9 months ago (2017-03-10 23:57:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738043004/1
3 years, 9 months ago (2017-03-11 00:02:42 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:41:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dccc4a73c2b74721e6b7f5ef3285...

Powered by Google App Engine
This is Rietveld 408576698