Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2738043003: Revert of Include the AppData file for Chrome and Chromium (Closed)

Created:
3 years, 9 months ago by fserb
Modified:
3 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org, phajdan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include the AppData file for Chrome and Chromium (patchset #4 id:60001 of https://codereview.chromium.org/2424093003/ ) Reason for revert: This is breaking linux build bot (again), please do not submit before fixing: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16722 Original issue's description: > Include the AppData file for Chrome and Chromium > > Add the two AppData files, one for Chromium and one for Chrome. The Chrome one > will be filled with the information from the common/google-chrome/google-chrome.info > file and should reflect the current channel (stable, beta, devel). On the other > side the Chromium one should be a general one and it will be reused by > distributions that are packaging the Chromium themselves. > > For AppData specification please see: > https://people.freedesktop.org/~hughsient/appdata/ > > BUG=654190 > > Review-Url: https://codereview.chromium.org/2424093003 > Cr-Original-Commit-Position: refs/heads/master@{#455457} > Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078 > Review-Url: https://codereview.chromium.org/2424093003 > Cr-Commit-Position: refs/heads/master@{#455731} > Committed: https://chromium.googlesource.com/chromium/src/+/caa17f475b1ccf16ce0d4f89902663f4462396a8 TBR=phajdan.jr@chromium.org,xhwang@chromium.org,tomas.popela@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654190 Review-Url: https://codereview.chromium.org/2738043003 Cr-Commit-Position: refs/heads/master@{#455753} Committed: https://chromium.googlesource.com/chromium/src/+/a2e1cecca25608406cfe391ef7f0836e666c6588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -79 lines) Patch
M chrome/installer/linux/BUILD.gn View 1 chunk +2 lines, -8 lines 0 comments Download
D chrome/installer/linux/common/chromium-browser/chromium-browser.appdata.xml View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/installer/linux/common/google-chrome/google-chrome.appdata.xml.template View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/installer/linux/common/installer.include View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/installer/linux/rpm/chrome.spec.template View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
fserb
Created Revert of Include the AppData file for Chrome and Chromium
3 years, 9 months ago (2017-03-09 15:54:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738043003/1
3 years, 9 months ago (2017-03-09 15:54:41 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 15:56:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2e1cecca25608406cfe391ef7f0...

Powered by Google App Engine
This is Rietveld 408576698