Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm

Issue 2738003002: Add title to current page in zero suggest. (Closed)
Patch Set: Fix a nullptr problem that was crashing some UI tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
index 1038d79585e861193def234d0385bb39af4d8bd2..b2565c350435b7a2908b6a1721eba8cb2e9d7712 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
@@ -211,31 +211,49 @@ TEST_F(OmniboxViewMacTest, WritingDirectionLTR) {
TEST_F(OmniboxViewMacTest, WritingDirectionRTL) {
cocoa_l10n_util::ScopedForceRTLMac rtl;
+ LOG(ERROR) << "1";
TestingToolbarModelDelegate delegate;
+ LOG(ERROR) << "1.1";
ToolbarModelImpl toolbar_model(&delegate, 32 * 1024);
+ LOG(ERROR) << "2";
TestingOmniboxEditController edit_controller(&toolbar_model);
+ LOG(ERROR) << "2.1";
OmniboxViewMac view(&edit_controller, profile(), NULL, NULL);
+ LOG(ERROR) << "3";
// This is deleted by the omnibox view.
MockOmniboxEditModel* model =
new MockOmniboxEditModel(&view, &edit_controller, profile());
+ LOG(ERROR) << "3.1";
MockOmniboxPopupView popup_view;
+ LOG(ERROR) << "3.2";
OmniboxPopupModel popup_model(&popup_view, model);
+ LOG(ERROR) << "3.3";
model->OnSetFocus(true);
+ LOG(ERROR) << "4";
SetModel(&view, model);
+ LOG(ERROR) << "4.1";
view.SetUserText(base::ASCIIToUTF16("foo.com"));
+ LOG(ERROR) << "4.2";
model->OnChanged();
+ LOG(ERROR) << "4.3";
base::scoped_nsobject<NSMutableAttributedString> string(
[[NSMutableAttributedString alloc] initWithString:@"foo.com"]);
+ LOG(ERROR) << "4.4";
view.ApplyTextStyle(string);
+ LOG(ERROR) << "4.5";
NSParagraphStyle* paragraphStyle =
[string attribute:NSParagraphStyleAttributeName
atIndex:0
effectiveRange:NULL];
+ LOG(ERROR) << "5";
DCHECK(paragraphStyle);
+ LOG(ERROR) << "5.1";
EXPECT_EQ(paragraphStyle.alignment, NSRightTextAlignment);
+ LOG(ERROR) << "5.2";
EXPECT_EQ(paragraphStyle.baseWritingDirection, NSWritingDirectionLeftToRight);
+ LOG(ERROR) << "5.3";
}

Powered by Google App Engine
This is Rietveld 408576698