chrome/browser/ui/omnibox/chrome_omnibox_client.cc - Issue 2738003002: Add title to current page in zero suggest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/chrome_omnibox_client.cc

Issue 2738003002: Add title to current page in zero suggest. (Closed)

Patch Set: Fix a nullptr problem that was crashing some UI tests. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/chrome_omnibox_client.cc

diff --git a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc

index c6f224e697e7efc67d101755fdab2e35a536f370..2896ad6104179f93a0d79bb1e4dae3c9c792176a 100644

--- a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc

+++ b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc

@@ -151,7 +151,9 @@ const GURL& ChromeOmniboxClient::GetURL() const {

}

const base::string16& ChromeOmniboxClient::GetTitle() const {

- return controller_->GetWebContents()->GetTitle();

+ static const auto* const kEmptyTitle = new base::string16();

Peter Kasting 2017/04/27 00:33:57 Don't do this; return EmptyString16() below instea

gcomanici 2017/04/27 02:11:23 Done.

+ return CurrentPageExists() ? controller_->GetWebContents()->GetTitle()

+ : *kEmptyTitle;

}

gfx::Image ChromeOmniboxClient::GetFavicon() const {