chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc - Issue 2738003002: Add title to current page in zero suggest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

Issue 2738003002: Add title to current page in zero suggest. (Closed)

Patch Set: Fix a nullptr problem that was crashing some UI tests. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc ('k') | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/ui/omnibox/chrome_omnibox_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc b/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

index 1b2b14b400226c230e27dd2e035d0c5e130d573e..5a9736e594366d6d558a9ed9a07855d40389939b 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

@@ -45,8 +45,9 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, PopupStaysClosed) {

// location_bar or location_bar->().

autocomplete_controller->Start(AutocompleteInput(

base::ASCIIToUTF16("keyword command"), base::string16::npos,

- std::string(), GURL(), metrics::OmniboxEventProto::NTP, true, false, true,

- true, false, ChromeAutocompleteSchemeClassifier(profile)));

+ std::string(), GURL(), base::string16(), metrics::OmniboxEventProto::NTP,

+ true, false, true, true, false,

+ ChromeAutocompleteSchemeClassifier(profile)));

location_bar->AcceptInput();

WaitForAutocompleteDone(autocomplete_controller);

EXPECT_TRUE(autocomplete_controller->done());