content/browser/gpu/gpu_data_manager_impl_private_unittest.cc - Issue 2737983002: WebGL feature will only enabled when accelerated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

Issue 2737983002: WebGL feature will only enabled when accelerated (Closed)

Patch Set: Restored kDisableSoftwareRasterizer for disabling SwiftShader Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

diff --git a/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc b/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

index 880a83fe77f85d13a6bc49778cb7ce6e6645addc..0aaf1b5274176f66075f5957c572e499ffc94142 100644

--- a/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

+++ b/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

@@ -300,7 +300,8 @@ TEST_F(GpuDataManagerImplPrivateTest, DisableHardwareAcceleration) {

manager->DisableHardwareAcceleration();

EXPECT_FALSE(manager->GpuAccessAllowed(&reason));

EXPECT_FALSE(reason.empty());

- EXPECT_EQ(static_cast<size_t>(gpu::NUMBER_OF_GPU_FEATURE_TYPES),

+ // SwiftShader is the only feature not getting disabled

+ EXPECT_EQ(static_cast<size_t>(gpu::NUMBER_OF_GPU_FEATURE_TYPES - 1),

manager->GetBlacklistedFeatureCount());

}