Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2737943002: Temporarily disable GestureFlingStart input DCHECK. (Closed)

Created:
3 years, 9 months ago by Daniele Castagna
Modified:
3 years, 9 months ago
Reviewers:
rjkroege, wjmaclean
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable GestureFlingStart input DCHECK. This DCHECK causes the browser process to crash and makes debuggining on a debug build (dchecks on) really tedious on ChromeOS. This CL temporarily disables the DCHECK while we work on a real fix. BUG=695187 Review-Url: https://codereview.chromium.org/2737943002 Cr-Commit-Position: refs/heads/master@{#455564} Committed: https://chromium.googlesource.com/chromium/src/+/74937dc645b191514bde662169aee3b29074b39d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Daniele Castagna
3 years, 9 months ago (2017-03-08 17:44:16 UTC) #3
wjmaclean
On 2017/03/08 17:44:16, Daniele Castagna wrote: lgtm Thanks for putting this CL up, sorry for ...
3 years, 9 months ago (2017-03-08 18:00:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737943002/1
3 years, 9 months ago (2017-03-08 18:57:23 UTC) #9
Daniele Castagna
+rjkroege for ownership.
3 years, 9 months ago (2017-03-08 19:06:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/381146)
3 years, 9 months ago (2017-03-08 19:07:48 UTC) #13
rjkroege
lgtm
3 years, 9 months ago (2017-03-08 22:11:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737943002/1
3 years, 9 months ago (2017-03-08 22:12:27 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 22:40:55 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74937dc645b191514bde662169ae...

Powered by Google App Engine
This is Rietveld 408576698