Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2737883002: Rename LayoutPart::widget to LayoutPart::frameViewBase (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, dshwang, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, Navid Zolghadr, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename LayoutPart::widget to LayoutPart::frameViewBase BUG=697351 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2737883002 Cr-Commit-Position: refs/heads/master@{#455397} Committed: https://chromium.googlesource.com/chromium/src/+/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename LayoutPart::widget to LayoutPart::frameViewBase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -63 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/PluginDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 10 chunks +16 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 34 (19 generated)
joelhockey
3 years, 9 months ago (2017-03-08 03:33:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737883002/1
3 years, 9 months ago (2017-03-08 03:34:07 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-08 03:34:08 UTC) #7
slangley
lgtm
3 years, 9 months ago (2017-03-08 03:40:44 UTC) #10
joelhockey
haraken ptal
3 years, 9 months ago (2017-03-08 03:44:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737883002/1
3 years, 9 months ago (2017-03-08 06:10:13 UTC) #16
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-08 06:10:15 UTC) #18
haraken
LGTM https://codereview.chromium.org/2737883002/diff/1/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp (right): https://codereview.chromium.org/2737883002/diff/1/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp#newcode499 third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp:499: static_cast<FrameView*>(toLayoutPart(object).frameViewBase()); We could use toFrameView.
3 years, 9 months ago (2017-03-08 06:13:26 UTC) #19
joelhockey
https://codereview.chromium.org/2737883002/diff/1/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp File third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp (right): https://codereview.chromium.org/2737883002/diff/1/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp#newcode499 third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp:499: static_cast<FrameView*>(toLayoutPart(object).frameViewBase()); On 2017/03/08 06:13:25, haraken wrote: > > We ...
3 years, 9 months ago (2017-03-08 06:24:30 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737883002/20001
3 years, 9 months ago (2017-03-08 06:24:57 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/3142)
3 years, 9 months ago (2017-03-08 06:34:11 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737883002/20001
3 years, 9 months ago (2017-03-08 06:45:38 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/3143)
3 years, 9 months ago (2017-03-08 06:54:50 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737883002/20001
3 years, 9 months ago (2017-03-08 06:57:56 UTC) #31
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 08:08:02 UTC) #34
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e1f7f7cc98ccc64094ebcbb0614...

Powered by Google App Engine
This is Rietveld 408576698