Avoid dependency on unspecified evaluation order of parameters.

Avoid dependency on unspecified evaluation order of parameters.

According to the standard, "the order of evaluation of arguments is
unspecified. All side effects of argument expression evaluations take
effect before the function is entered."

This mean that |site| may be moved before |site.url| or |IconType|
are evaluated, thus having them access a moved object (returning
unspecified values).

BUG=None

Review-Url: https://codereview.chromium.org/2737873002
Cr-Commit-Position: refs/heads/master@{#455515}
Committed: https://chromium.googlesource.com/chromium/src/+/2bc5b5fb3da0c205a025535faff4fb160ca6467a

[sdefresne, 2017-03-08 02:50:39]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 02:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-08 02:51:14]

sdefresne@chromium.org changed reviewers:
+ sfiera@chromium.org

[sdefresne, 2017-03-08 02:51:15]

I saw this while investigating an issue (unrelated) but though it would be good
to fix. Please take a look.

[commit-bot: I haz the power, 2017-03-08 04:18:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:18:28]

Dry run: This issue passed the CQ dry run.

[sfiera, 2017-03-08 09:38:54]

LGTM

https://codereview.chromium.org/2737873002/diff/1/components/ntp_tiles/icon_c...
File components/ntp_tiles/icon_cacher_impl.cc (right):

https://codereview.chromium.org/2737873002/diff/1/components/ntp_tiles/icon_c...
components/ntp_tiles/icon_cacher_impl.cc:55: // it is moved.
I think "copy values from |site| before it is moved" is enough of a comment
here.

[sdefresne, 2017-03-08 18:35:25]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-03-08 18:35:25]

The patchset sent to the CQ was uploaded after l-g-t-m from sfiera@chromium.org
Link to the patchset: https://codereview.chromium.org/2737873002/#ps20001
(title: "Update comment.")

[sdefresne, 2017-03-08 18:35:35]

Thank you.

https://codereview.chromium.org/2737873002/diff/1/components/ntp_tiles/icon_c...
File components/ntp_tiles/icon_cacher_impl.cc (right):

https://codereview.chromium.org/2737873002/diff/1/components/ntp_tiles/icon_c...
components/ntp_tiles/icon_cacher_impl.cc:55: // it is moved.
On 2017/03/08 09:38:54, sfiera wrote:
> I think "copy values from |site| before it is moved" is enough of a comment
> here.

Done.

[commit-bot: I haz the power, 2017-03-08 18:36:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 19:36:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488998125535690,
"parent_rev": "db995c23f79d3ab26300676f8c431b7e4c115ad4", "commit_rev":
"2bc5b5fb3da0c205a025535faff4fb160ca6467a"}

[commit-bot: I haz the power, 2017-03-08 19:37:47]

Description was changed from

==========
Avoid dependency on unspecified evaluation order of parameters.

According to the standard, "the order of evaluation of arguments is
unspecified. All side effects of argument expression evaluations take
effect before the function is entered."

This mean that |site| may be moved before |site.url| or |IconType|
are evaluated, thus having them access a moved object (returning
unspecified values).

BUG=None
==========

to

==========
Avoid dependency on unspecified evaluation order of parameters.

According to the standard, "the order of evaluation of arguments is
unspecified. All side effects of argument expression evaluations take
effect before the function is entered."

This mean that |site| may be moved before |site.url| or |IconType|
are evaluated, thus having them access a moved object (returning
unspecified values).

BUG=None

Review-Url: https://codereview.chromium.org/2737873002
Cr-Commit-Position: refs/heads/master@{#455515}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bc5b5fb3da0c205a025535faff4...
==========

[commit-bot: I haz the power, 2017-03-08 19:37:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2bc5b5fb3da0c205a025535faff4...