Source/core/css/invalidation/StyleInvalidator.cpp - Issue 273783003: Don't schedule invalidations when attributes changed if not needed or incorrect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/invalidation/StyleInvalidator.cpp

Issue 273783003: Don't schedule invalidations when attributes changed if not needed or incorrect. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add some styleChangeType() < SubtreeStyleChange checks in ContainerNode. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css/invalidation/style-invalidation-before-attach-expected.html ('k') | Source/core/dom/ContainerNode.cpp » ('j') | Source/core/dom/Element.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/invalidation/StyleInvalidator.cpp

diff --git a/Source/core/css/invalidation/StyleInvalidator.cpp b/Source/core/css/invalidation/StyleInvalidator.cpp

index 4b9a24cec661e254a1a8deafe63cbcaf000422e2..530b8bfa84d2b1905eb3dc38c41e507b9048478d 100644

--- a/Source/core/css/invalidation/StyleInvalidator.cpp

+++ b/Source/core/css/invalidation/StyleInvalidator.cpp

@@ -28,6 +28,8 @@ void StyleInvalidator::invalidate(Document& document)

void StyleInvalidator::scheduleInvalidation(PassRefPtr<DescendantInvalidationSet> invalidationSet, Element& element)

{

+ ASSERT(element.inActiveDocument());

+ ASSERT(element.styleChangeType() < SubtreeStyleChange);

InvalidationList& list = ensurePendingInvalidationList(element);

// If we're already going to invalidate the whole subtree we don't need to store any new sets.

if (!list.isEmpty() && list.last()->wholeSubtreeInvalid())

@@ -51,8 +53,6 @@ void StyleInvalidator::clearInvalidation(Node& node)

{

if (node.isElementNode() && node.needsStyleInvalidation())

m_pendingInvalidationMap.remove(toElement(&node));

- node.clearChildNeedsStyleInvalidation();

- node.clearNeedsStyleInvalidation();

}

void StyleInvalidator::clearPendingInvalidations()